Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 2748203002: Remove usage of USE_SYSTEM_PROTOBUF (Closed)

Created:
3 years, 9 months ago by Tom Anderson
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, vakh+watch_chromium.org, chromoting-reviews_chromium.org, Randy Smith (Not in Mondays), timvolodine, oshima+watch_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of USE_SYSTEM_PROTOBUF It's no longer possible to build using the system libprotobuf, so the macro USE_SYSTEM_PROTOBUF is not set anywhere. This CL removes all usages of it. R=jam@chromium.org Review-Url: https://codereview.chromium.org/2748203002 Cr-Commit-Position: refs/heads/master@{#462363} Committed: https://chromium.googlesource.com/chromium/src/+/4b7c48089ce5ee9d1a2e4530a82f6bd31e398bbd

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/omnibox/browser/url_index_private_data.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/safe_browsing_db/v4_rice.h View 1 chunk +0 lines, -5 lines 0 comments Download
M dbus/message.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/protocol/message_decoder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/protocol/message_serialization.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
Tom (Use chromium acct)
jam@ ptal
3 years, 9 months ago (2017-03-14 19:10:04 UTC) #2
Tom (Use chromium acct)
pinging jam@
3 years, 9 months ago (2017-03-27 17:53:37 UTC) #6
jam
lgtm
3 years, 8 months ago (2017-03-28 23:56:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748203002/1
3 years, 8 months ago (2017-03-28 23:59:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/259806)
3 years, 8 months ago (2017-03-29 01:26:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748203002/1
3 years, 8 months ago (2017-03-31 18:04:40 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/181804) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-03-31 18:07:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748203002/40001
3 years, 8 months ago (2017-03-31 18:17:09 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/184827)
3 years, 8 months ago (2017-03-31 18:39:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748203002/40001
3 years, 8 months ago (2017-04-06 04:20:29 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 05:30:28 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4b7c48089ce5ee9d1a2e4530a82f...

Powered by Google App Engine
This is Rietveld 408576698