Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2748183005: Update linux sysroot from Wheezy to Jessie (Closed)

Created:
3 years, 9 months ago by Sam Clegg
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, grt+watch_chromium.org, piman+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org, kalyank, Michael Moss, tonikitoo, msisov(use msisov igalia.com), fwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update linux sysroot from Wheezy to Jessie This is an attempt to reland a change that was attempted several times already. It now includes changes to the linux packaging expectations which previously caused failed on the official bots. TESTED=ninja linux_packages_all BUG=701894 Review-Url: https://codereview.chromium.org/2748183005 Cr-Commit-Position: refs/heads/master@{#459062} Committed: https://chromium.googlesource.com/chromium/src/+/94c4fa81c45284d0fe1e5616f52fcad56745077b

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : update deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -76 lines) Patch
M build/config/sysroot.gni View 2 chunks +6 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 4 chunks +25 lines, -33 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32_jessie View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 2 2 chunks +3 lines, -2 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 38 (22 generated)
Sam Clegg
This issue still needs to be resolved before we can land this change: https://bugs.chromium.org/p/chromium/issues/detail?id=701478&desc=2
3 years, 9 months ago (2017-03-16 19:03:53 UTC) #4
Lei Zhang
https://codereview.chromium.org/2748183005/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/2748183005/diff/1/tools/checklicenses/checklicenses.py#newcode652 tools/checklicenses/checklicenses.py:652: 'build/linux/debian_jessie_amd64-sysroot', sort https://codereview.chromium.org/2748183005/diff/1/tools/copyright_scanner/copyright_scanner.py File tools/copyright_scanner/copyright_scanner.py (right): https://codereview.chromium.org/2748183005/diff/1/tools/copyright_scanner/copyright_scanner.py#newcode73 tools/copyright_scanner/copyright_scanner.py:73: path_join('build', ...
3 years, 9 months ago (2017-03-16 19:17:28 UTC) #5
Lei Zhang
New expected_deps changes lgtm
3 years, 9 months ago (2017-03-16 19:27:42 UTC) #6
Sam Clegg
On 2017/03/16 19:27:42, Lei Zhang wrote: > New expected_deps changes lgtm crbug/701478 should now be ...
3 years, 9 months ago (2017-03-22 18:39:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748183005/20001
3 years, 9 months ago (2017-03-22 18:40:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/391829) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-22 18:44:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748183005/40001
3 years, 9 months ago (2017-03-22 19:59:26 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/391924)
3 years, 9 months ago (2017-03-22 20:07:36 UTC) #24
Sam Clegg
Looks lgeez from Dirk and Nico should be sufficient. Hopefully this time this change will ...
3 years, 9 months ago (2017-03-22 20:18:14 UTC) #26
Nico
lgtm!
3 years, 9 months ago (2017-03-22 20:23:05 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748183005/40001
3 years, 9 months ago (2017-03-22 20:28:46 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/345799)
3 years, 9 months ago (2017-03-22 21:06:02 UTC) #31
Tom Anderson
lgtm
3 years, 9 months ago (2017-03-23 00:53:24 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748183005/40001
3 years, 9 months ago (2017-03-23 12:57:25 UTC) #34
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/94c4fa81c45284d0fe1e5616f52fcad56745077b
3 years, 9 months ago (2017-03-23 13:02:07 UTC) #37
Mike Wittman
3 years, 9 months ago (2017-03-23 17:23:15 UTC) #38
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2776503002/ by wittman@chromium.org.

The reason for reverting is: Breaks the Official Linux build. Expected deps
aren't matching up:

[30924/30936] ACTION
//chrome/installer/linux:stable_rpm(//build/toolchain/linux:clang_x64)
FAILED: google-chrome-stable_59.0.3050.0-1.x86_64.rpm 
python ../../chrome/installer/linux/flock_make_package.py linux_package.lock
installer/rpm/build.sh -o . -b . -a x64 -c stable -d google_chrome
Staging common install files in '/tmp/rpm.build.PQ88Wk'...
Staging RPM install files in '/tmp/rpm.build.PQ88Wk'...
Packaging x86_64...
---
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/rpm/expected_deps_x86_64	2017-03-23
06:48:22.885425473 -0700
+++ /dev/fd/63	2017-03-23 08:04:33.320136041 -0700
@@ -15,7 +15,9 @@
 libasound.so.2()(64bit)
 libatk-1.0.so.0()(64bit)
 libc.so.6()(64bit)
+libc.so.6(GLIBC_2.11)(64bit)
 libc.so.6(GLIBC_2.14)(64bit)
+libc.so.6(GLIBC_2.15)(64bit)
 libc.so.6(GLIBC_2.2.5)(64bit)
 libc.so.6(GLIBC_2.3)(64bit)
 libc.so.6(GLIBC_2.3.2)(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64

[30925/30936] ACTION
//chrome/installer/linux:unstable_deb(//build/toolchain/linux:clang_x64)
FAILED: google-chrome-unstable_59.0.3050.0-1_amd64.deb 
python ../../chrome/installer/linux/flock_make_package.py linux_package.lock
installer/debian/build.sh -o . -b . -a x64 -c unstable -d google_chrome -s
/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot
dpkg-shlibdeps: warning: binaries to analyze should already be installed in
their package's directory
---
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_jessie	2017-03-23
06:48:22.885425473 -0700
+++ actual	2017-03-23 08:04:37.504250895 -0700
@@ -1,17 +1,17 @@
 gconf-service
 libasound2 (>= 1.0.16)
 libatk1.0-0 (>= 1.12.4)
-libc6 (>= 2.14)
+libc6 (>= 2.15)
 libcairo2 (>= 1.6.0)
 libcups2 (>= 1.4.0)
-libdbus-1-3 (>= 1.2.14)
+libdbus-1-3 (>= 1.1.4)
 libexpat1 (>= 2.0.1)
 libfontconfig1 (>= 2.11)
-libfreetype6 (>= 2.4.2)
+libfreetype6 (>= 2.3.9)
 libgcc1 (>= 1:4.1.1)
 libgconf-2-4 (>= 3.2.5)
 libgdk-pixbuf2.0-0 (>= 2.22.0)
-libglib2.0-0 (>= 2.31.8)
+libglib2.0-0 (>= 2.28.0)
 libgtk-3-0 (>= 3.3.16)
 libnspr4 (>= 2:4.9-2~)
 libnss3 (>= 2:3.13.4-2~)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32_jessie
chrome/installer/linux/debian/expected_deps_ia32_wheezy
chrome/installer/linux/debian/expected_deps_x64_jessie
chrome/installer/linux/debian/expected_deps_x64_wheezy.

Powered by Google App Engine
This is Rietveld 408576698