Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2748133007: Remove ScopedVector from ipc/. (Closed)

Created:
3 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), Avi (use Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from ipc/. base::ScopedVector is deprecated, see bug. BUG=554289 Review-Url: https://codereview.chromium.org/2748133007 Cr-Commit-Position: refs/heads/master@{#457658} Committed: https://chromium.googlesource.com/chromium/src/+/c9a4560e7a2b4231d6db101f0aea335736ff3d19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M ipc/ipc_channel_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
leonhsl(Using Gerrit)
Hi, Tom, PTAL if trybots are all green :) #Today I can't wait for the ...
3 years, 9 months ago (2017-03-16 10:51:05 UTC) #4
Tom Sepez
LGTM, thanks!
3 years, 9 months ago (2017-03-16 18:00:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748133007/1
3 years, 9 months ago (2017-03-17 02:02:22 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 02:07:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9a4560e7a2b4231d6db101f0aea...

Powered by Google App Engine
This is Rietveld 408576698