Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2748133004: [Payments] View controllers no longer have access to PaymentRequest (Closed)

Created:
3 years, 9 months ago by Mathieu
Modified:
3 years, 9 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] View controllers no longer have access to PaymentRequest Instead, we pass them PaymentRequestSpec and PaymentRequestState. BUG=701345 TEST=existing Review-Url: https://codereview.chromium.org/2748133004 Cr-Commit-Position: refs/heads/master@{#457136} Committed: https://chromium.googlesource.com/chromium/src/+/8be5c3fbeef96d6e423f4e468b6d3c49fe99490a

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -200 lines) Patch
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/editor_view_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/editor_view_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/order_summary_view_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/order_summary_view_controller.cc View 4 chunks +17 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.cc View 5 chunks +33 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_item_list.h View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_item_list.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.h View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 13 chunks +35 lines, -46 lines 0 comments Download
M chrome/browser/ui/views/payments/profile_list_view_controller.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/payments/profile_list_view_controller.cc View 7 chunks +37 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_option_view_controller.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/shipping_option_view_controller.cc View 5 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Mathieu
Hi Anthony, did some professional plumbing this morning, PTAL!
3 years, 9 months ago (2017-03-15 15:01:15 UTC) #7
anthonyvd
lgtm
3 years, 9 months ago (2017-03-15 17:52:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748133004/20001
3 years, 9 months ago (2017-03-15 17:53:24 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:00:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8be5c3fbeef96d6e423f4e468b6d...

Powered by Google App Engine
This is Rietveld 408576698