Pull AudioDestinationConsumer off the Blink GC heap.

Pull AudioDestinationConsumer off the Blink GC heap.

The AudioDestinationConsumer interface and its single implementation
does not meet the bar for being on the Blink GC heap. It doesn't cause
harm to have them there, but in order to diagnose an unexplained
failure, pull these objects off the heap.

We may want to restore them to the Blink GC heap once the issue has
been resolved.

R=
BUG=682945
Review-Url: https://codereview.chromium.org/2748133003
Cr-Commit-Position: refs/heads/master@{#456736}
Committed: https://chromium.googlesource.com/chromium/src/+/bb9b04fe0965eeb09f229f7a727fe7235add810f

[sof, 2017-03-14 15:13:48]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 15:14:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-03-14 15:27:30]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, hongchan@chromium.org, rtoy@chromium.org

[sof, 2017-03-14 15:27:31]

please take a look.

I'd like to try this out - if it proves effective, it clearly wouldn't explain
the bug we're faced with right now.

[Raymond Toy, 2017-03-14 15:31:32]

On 2017/03/14 15:27:31, sof wrote:
> please take a look.
> 
> I'd like to try this out - if it proves effective, it clearly wouldn't explain
> the bug we're faced with right now.

Would or wouldn't explain the bug?

lgtm for the platform/audio part.

[sof, 2017-03-14 15:36:35]

On 2017/03/14 15:31:32, Raymond Toy wrote:
> On 2017/03/14 15:27:31, sof wrote:
> > please take a look.
> > 
> > I'd like to try this out - if it proves effective, it clearly wouldn't
explain
> > the bug we're faced with right now.
> 
> Would or wouldn't explain the bug?
> 
> lgtm for the platform/audio part.

It would be a workaround for a heap overwrite, so it wouldn't pick out where/how
that enters.

[hongchan, 2017-03-14 16:01:13]

rtoy@ already gave one but - lgtm for platform/audio.

[commit-bot: I haz the power, 2017-03-14 16:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[haraken, 2017-03-14 16:41:09]

LGTM

[sof, 2017-03-14 16:52:17]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-03-14 16:52:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 16:56:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489510337348280, "parent_rev":
"09165f0b1ceba1bb69afa0e786e323839acefe3b", "commit_rev":
"bb9b04fe0965eeb09f229f7a727fe7235add810f"}

[commit-bot: I haz the power, 2017-03-14 16:57:32]

Description was changed from

==========
Pull AudioDestinationConsumer off the Blink GC heap.

The AudioDestinationConsumer interface and its single implementation
does not meet the bar for being on the Blink GC heap. It doesn't cause
harm to have them there, but in order to diagnose an unexplained
failure, pull these objects off the heap.

We may want to restore them to the Blink GC heap once the issue has
been resolved.

R=
BUG=682945
==========

to

==========
Pull AudioDestinationConsumer off the Blink GC heap.

The AudioDestinationConsumer interface and its single implementation
does not meet the bar for being on the Blink GC heap. It doesn't cause
harm to have them there, but in order to diagnose an unexplained
failure, pull these objects off the heap.

We may want to restore them to the Blink GC heap once the issue has
been resolved.

R=
BUG=682945

Review-Url: https://codereview.chromium.org/2748133003
Cr-Commit-Position: refs/heads/master@{#456736}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb9b04fe0965eeb09f229f7a727f...
==========

[commit-bot: I haz the power, 2017-03-14 16:57:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb9b04fe0965eeb09f229f7a727f...