xvfb.py complains if command points to a directory.

xvfb.py complains if command points to a directory.

An update to xvfb.py changed its input arguments and the previously
required first one pointing to the execution directory has been removed.
This change adds makes it backwards-aware: if the first argument, now
expected to be the command, points to a directory it exists gracefully
with a helpful error message.

BUG=

Review-Url: https://codereview.chromium.org/2748123004
Cr-Commit-Position: refs/heads/master@{#456957}
Committed: https://chromium.googlesource.com/chromium/src/+/cac17251a3c186a7cc91e27c6de76899f162215c

[carlosk, 2017-03-14 22:15:05]

carlosk@chromium.org changed reviewers:
+ dpranke@chromium.org, thomasanderson@chromium.org

[carlosk, 2017-03-14 22:15:06]

dpranke@: PTAL.

thomasanderson@: FY.

[Tom Anderson, 2017-03-14 22:43:43]

lgtm

https://codereview.chromium.org/2748123004/diff/1/testing/xvfb.py
File testing/xvfb.py (right):

https://codereview.chromium.org/2748123004/diff/1/testing/xvfb.py#newcode88
testing/xvfb.py:88: if os.path.isdir(sys.argv[1]):
nit: add a comment explaining why we have this case

[carlosk, 2017-03-14 23:47:23]

Thanks.

https://codereview.chromium.org/2748123004/diff/1/testing/xvfb.py
File testing/xvfb.py (right):

https://codereview.chromium.org/2748123004/diff/1/testing/xvfb.py#newcode88
testing/xvfb.py:88: if os.path.isdir(sys.argv[1]):
On 2017/03/14 22:43:43, Thomas Anderson wrote:
> nit: add a comment explaining why we have this case

Done.

[Dirk Pranke, 2017-03-14 23:47:33]

lgtm

[carlosk, 2017-03-14 23:52:09]

The CQ bit was checked by carlosk@chromium.org

[carlosk, 2017-03-14 23:52:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
thomasanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2748123004/#ps20001
(title: "Adds comment.")

[commit-bot: I haz the power, 2017-03-14 23:53:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:27:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:27:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[carlosk, 2017-03-15 00:37:20]

I took advantage of the (unrelated) CQ failure to improve the error message to
specifically mention the wrong command value.

[carlosk, 2017-03-15 01:01:57]

The CQ bit was checked by carlosk@chromium.org

[carlosk, 2017-03-15 01:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, thomasanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2748123004/#ps40001
(title: "Better error message.")

[commit-bot: I haz the power, 2017-03-15 01:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:21:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489539717877730,
"parent_rev": "3824c55fa682cafe038041adc75a0d478717dbca", "commit_rev":
"cac17251a3c186a7cc91e27c6de76899f162215c"}

[commit-bot: I haz the power, 2017-03-15 02:21:57]

Description was changed from

==========
xvfb.py complains if command points to a directory.

An update to xvfb.py changed its input arguments and the previously
required first one pointing to the execution directory has been removed.
This change adds makes it backwards-aware: if the first argument, now
expected to be the command, points to a directory it exists gracefully
with a helpful error message.

BUG=
==========

to

==========
xvfb.py complains if command points to a directory.

An update to xvfb.py changed its input arguments and the previously
required first one pointing to the execution directory has been removed.
This change adds makes it backwards-aware: if the first argument, now
expected to be the command, points to a directory it exists gracefully
with a helpful error message.

BUG=

Review-Url: https://codereview.chromium.org/2748123004
Cr-Commit-Position: refs/heads/master@{#456957}
Committed:
https://chromium.googlesource.com/chromium/src/+/cac17251a3c186a7cc91e27c6de7...
==========

[commit-bot: I haz the power, 2017-03-15 02:21:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cac17251a3c186a7cc91e27c6de7...