Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2748113002: Set undefined when calling a %TypedArray%.indexOf withtout arguments (Closed)

Created:
3 years, 9 months ago by Choongwoo Han
Modified:
3 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Set undefined when calling %TypedArray%.indexOf without arguments Set undefined to the first argument (search element) if the first argument is not given in %TypedArray%.prototype.indexOf or %TypedArray%.prototype.includes BUG=chromium:700894 Review-Url: https://codereview.chromium.org/2748113002 Cr-Commit-Position: refs/heads/master@{#43794} Committed: https://chromium.googlesource.com/v8/v8/+/af63679d0531992f70ed96db58b72b1b3449aa48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins/builtins-typedarray.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Choongwoo Han
PTAL. btw, Webkit (safari) raises a TypeException for this case while FireFox and Chrome do ...
3 years, 9 months ago (2017-03-14 13:13:17 UTC) #3
Camillo Bruni
lgtm
3 years, 9 months ago (2017-03-14 15:55:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748113002/1
3 years, 9 months ago (2017-03-14 16:04:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36621)
3 years, 9 months ago (2017-03-14 16:07:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748113002/1
3 years, 9 months ago (2017-03-14 16:08:50 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:26:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/af63679d0531992f70ed96db58b72b1b344...

Powered by Google App Engine
This is Rietveld 408576698