Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2748093005: Swap two methods. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 2 chunks +24 lines, -24 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
It always confuses me that writeProgram comes before writeOutline as the latter is invoked first.
3 years, 9 months ago (2017-03-15 11:28:07 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-15 11:46:23 UTC) #3
ahe
3 years, 9 months ago (2017-03-15 14:28:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06a6ba14a304518623a4165a336f1bf0d5c834ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698