Move patch file generation to fasta.

Move deps file generation to fasta.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a228e0b2d7bf337f0e4ab5bff8e0fdd82dd4edeb

[ahe, 2017-03-15 12:56:49]

ahe@google.com changed reviewers:
+ vegorov@google.com

[ahe, 2017-03-15 12:57:05]

Description was changed from

==========
Move patch file generation to fasta.
==========

to

==========
Move deps file generation to fasta.
==========

[ahe, 2017-03-15 12:57:27]

Updated CL description: it's deps file, not patch file.

[Vyacheslav Egorov (Google), 2017-03-15 13:43:59]

lgtm

https://codereview.chromium.org/2742333006/diff/1/tools/patch_sdk.dart
File tools/patch_sdk.dart (right):

https://codereview.chromium.org/2742333006/diff/1/tools/patch_sdk.dart#newcode48
tools/patch_sdk.dart:48: try {
With such a gigantic try { } finally { } it might be better to split it like
this:

Future main(List<String> argv) async {
  var port = new ...;
  try {
    return mainImpl(argv, port);
  } finally {
    port.close();
  }
}

[ahe, 2017-03-15 14:42:29]

Description was changed from

==========
Move deps file generation to fasta.
==========

to

==========
Move deps file generation to fasta.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a228e0b2d7bf337f0e4ab5bff8e0fdd82dd4edeb
==========

[ahe, 2017-03-15 14:42:30]

Committed patchset #2 (id:20001) manually as
a228e0b2d7bf337f0e4ab5bff8e0fdd82dd4edeb (presubmit successful).

[ahe, 2017-03-31 15:05:02]

https://codereview.chromium.org/2742333006/diff/1/tools/patch_sdk.dart
File tools/patch_sdk.dart (right):

https://codereview.chromium.org/2742333006/diff/1/tools/patch_sdk.dart#newcode48
tools/patch_sdk.dart:48: try {
On 2017/03/15 13:43:59, Vyacheslav Egorov (Google) wrote:
> With such a gigantic try { } finally { } it might be better to split it like
> this:
> 
> Future main(List<String> argv) async {
>   var port = new ...;
>   try {
>     return mainImpl(argv, port);
>   } finally {
>     port.close();
>   }
> }

Done.