Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: milo/appengine/buildbucket/builder.go

Issue 2748073006: Milo Refactor: Remove theme support (Closed)
Patch Set: Review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbucket/builder.go
diff --git a/milo/appengine/buildbucket/builder.go b/milo/appengine/buildbucket/builder.go
index d9ebaace636186a3f726f214f9c7f7909c313099..4742c8099b256cca74ccae9391fae9d9ebf9c1ff 100644
--- a/milo/appengine/buildbucket/builder.go
+++ b/milo/appengine/buildbucket/builder.go
@@ -219,9 +219,17 @@ func getDebugBuilds(c context.Context, bucket, builder string, maxCompletedBuild
return nil
}
+type builderQuery struct {
+ Server string
+ Bucket string
+ Builder string
+ Limit int
+}
+
// builderImpl is the implementation for getting a milo builder page from buildbucket.
// if maxCompletedBuilds < 0, 25 is used.
-func builderImpl(c context.Context, server, bucket, builder string, maxCompletedBuilds int) (*resp.Builder, error) {
+func builderImpl(c context.Context, q *builderQuery) (*resp.Builder, error) {
+ server, bucket, builder, maxCompletedBuilds := q.Server, q.Bucket, q.Builder, q.Limit
nodir 2017/03/17 20:47:57 please accept builderQuery instead of *builderQuer
hinoka 2017/03/17 22:04:54 Done.
if maxCompletedBuilds < 0 {
maxCompletedBuilds = 20
}

Powered by Google App Engine
This is Rietveld 408576698