Milo Refactor: Remove theme support

milo/appengine/buildbucket/builder.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbucket
 
 import (
         "encoding/json"
         "fmt"
         "net/url"
@@ skipping 201 matching lines @@
                                 target.FinishedBuilds = append(target.FinishedBuilds, mb)
                         }
 
                 default:
                         panic("impossible")
                 }
         }
         return nil
 }
 
+type builderQuery struct {
+        Server  string
+        Bucket  string
+        Builder string
+        Limit   int
+}
+
 // builderImpl is the implementation for getting a milo builder page from buildbucket.
 // if maxCompletedBuilds < 0, 25 is used.
-func builderImpl(c context.Context, server, bucket, builder string, maxCompletedBuilds int) (*resp.Builder, error) {
+func builderImpl(c context.Context, q *builderQuery) (*resp.Builder, error) {
+        server, bucket, builder, maxCompletedBuilds := q.Server, q.Bucket, q.Builder, q.Limit

[nodir, 2017/03/17 20:47:57]

please accept builderQuery instead of *builderQuery, so that you can safely
mutate q and inline these variables

[hinoka, 2017/03/17 22:04:54]

Done.

         if maxCompletedBuilds < 0 {
                 maxCompletedBuilds = 20
         }
 
         result := &resp.Builder{
                 Name: builder,
         }
         if server == "debug" {
                 return result, getDebugBuilds(c, bucket, builder, maxCompletedBuilds, result)
         }
@@ skipping 38 matching lines @@
         return time.Unix(microseconds/1e6, microseconds%1e6*1000).UTC()
 }
 
 type newBuildsFirst []*resp.BuildSummary
 
 func (a newBuildsFirst) Len() int      { return len(a) }
 func (a newBuildsFirst) Swap(i, j int) { a[i], a[j] = a[j], a[i] }
 func (a newBuildsFirst) Less(i, j int) bool {
         return a[i].PendingTime.Started.After(a[j].PendingTime.Started)
 }