Milo Refactor: Remove theme support

milo/appengine/frontend/milo.go

Index: milo/appengine/frontend/milo.go
diff --git a/milo/appengine/frontend/milo.go b/milo/appengine/frontend/milo.go
index 178976c78d363408b9f28dfd3a90d23a1a895f05..07caba8a54f819ce31860f47af4e394895ac850b 100644
--- a/milo/appengine/frontend/milo.go
+++ b/milo/appengine/frontend/milo.go
@@ -36,37 +36,43 @@ func init() {
 	gaemiddleware.InstallHandlers(r, gaemiddleware.BaseProd())
 
 	basemw := settings.Base()
-	r.GET("/", basemw, settings.Wrap(frontpage{}))
+	r.GET("/", basemw, settings.Wrap(frontpageHandler, "frontpage.html"))

[nodir, 2017/03/16 17:42:51]

i don't see a reason to decouple handler functions and template names. No other
template would work for the arguments returned by the function. I'd make
handlers self-sufficient and remove the knowledge of template names from this
file by moving template names into the handler functions, see my other
suggestion in buildbot/html.go

here is how luci scheduler does this
https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/schedul...

[hinoka, 2017/03/17 20:00:21]

Done.

 
 	// Admin and cron endpoints.
 	r.GET("/admin/update", basemw.Extend(gaemiddleware.RequireCron),
 		settings.UpdateHandler)
-	r.GET("/admin/configs", basemw, settings.Wrap(settings.ViewConfigs{}))
+	r.GET("/admin/configs", basemw,
+		settings.Wrap(settings.ConfigsHandler, "configs.html"))
 
 	// Console
-	r.GET("/console/:project/:name", basemw, settings.Wrap(console.Console{}))
+	r.GET("/console/:project/:name", basemw,
+		settings.Wrap(console.ConsoleHandler, "console.html"))
 	r.GET("/console/:project", basemw, console.Main)
 
 	// Swarming
-	r.GET("/swarming/task/:id/steps/*logname", basemw, settings.Wrap(swarming.Log{}))
-	r.GET("/swarming/task/:id", basemw, settings.Wrap(swarming.Build{}))
-	// Backward-compatible URLs:
-	r.GET("/swarming/prod/:id/steps/*logname", basemw, settings.Wrap(swarming.Log{}))
-	r.GET("/swarming/prod/:id", basemw, settings.Wrap(swarming.Build{}))
+	r.GET("/swarming/task/:id/steps/*logname", basemw,
+		settings.Wrap(swarming.LogHandler, "log.html"))
+	r.GET("/swarming/task/:id", basemw, settings.Wrap(
+		swarming.BuildHandler, "build.html"))
+	// Backward-compatible URLs for Swarming:
+	r.GET("/swarming/prod/:id/steps/*logname", basemw,
+		settings.Wrap(swarming.LogHandler, "log.html"))
+	r.GET("/swarming/prod/:id", basemw,
+		settings.Wrap(swarming.BuildHandler, "build.html"))
 
 	// Buildbucket
-	r.GET("/buildbucket/:bucket/:builder", basemw, settings.Wrap(buildbucket.Builder{}))
+	r.GET("/buildbucket/:bucket/:builder", basemw,
+		settings.Wrap(buildbucket.BuilderHandler, "builder.html"))
 
 	// Buildbot
-	r.GET("/buildbot/:master/:builder/:build", basemw, settings.Wrap(buildbot.Build{}))
-	r.GET("/buildbot/:master/:builder/", basemw, settings.Wrap(buildbot.Builder{}))
+	r.GET("/buildbot/:master/:builder/:build", basemw,
+		settings.Wrap(buildbot.BuildHandler, "build.html"))
+	r.GET("/buildbot/:master/:builder/", basemw,
+		settings.Wrap(buildbot.BuilderHandler, "builder.html"))
 
 	// LogDog Milo Annotation Streams.
-	r.GET("/logdog/build/:project/*path", basemw, settings.Wrap(&logdog.AnnotationStreamHandler{}))
-
-	// User settings
-	r.GET("/settings", basemw, settings.Wrap(settings.Settings{}))
-	r.POST("/settings", basemw, settings.ChangeSettings)
+	r.GET("/logdog/build/:project/*prefix", basemw,
+		settings.Wrap(logdog.BuildHandler, "build.html"))
 
 	// PubSub subscription endpoints.
 	r.POST("/pubsub/buildbot", basemw, buildbot.PubSubHandler)