Milo Refactor: Remove theme support

milo/appengine/frontend/milo.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package frontend
 
 import (
         "net/http"
 
         "github.com/golang/protobuf/proto"
@@ skipping 18 matching lines @@
         return c, nil
 }
 
 // Where it all begins!!!
 func init() {
         // Register plain ol' http handlers.
         r := router.New()
         gaemiddleware.InstallHandlers(r, gaemiddleware.BaseProd())
 
         basemw := settings.Base()
-        r.GET("/", basemw, settings.Wrap(frontpage{}))
+        r.GET("/", basemw, settings.Wrap(frontpageHandler, "frontpage.html"))

[nodir, 2017/03/16 17:42:51]

i don't see a reason to decouple handler functions and template names. No other
template would work for the arguments returned by the function. I'd make
handlers self-sufficient and remove the knowledge of template names from this
file by moving template names into the handler functions, see my other
suggestion in buildbot/html.go

here is how luci scheduler does this
https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/schedul...

[hinoka, 2017/03/17 20:00:21]

Done.

 
         // Admin and cron endpoints.
         r.GET("/admin/update", basemw.Extend(gaemiddleware.RequireCron),
                 settings.UpdateHandler)
-        r.GET("/admin/configs", basemw, settings.Wrap(settings.ViewConfigs{}))
+        r.GET("/admin/configs", basemw,
+                settings.Wrap(settings.ConfigsHandler, "configs.html"))
 
         // Console
-        r.GET("/console/:project/:name", basemw, settings.Wrap(console.Console{}))
+        r.GET("/console/:project/:name", basemw,
+                settings.Wrap(console.ConsoleHandler, "console.html"))
         r.GET("/console/:project", basemw, console.Main)
 
         // Swarming
-        r.GET("/swarming/task/:id/steps/*logname", basemw, settings.Wrap(swarming.Log{}))
-        r.GET("/swarming/task/:id", basemw, settings.Wrap(swarming.Build{}))
-        // Backward-compatible URLs:
-        r.GET("/swarming/prod/:id/steps/*logname", basemw, settings.Wrap(swarming.Log{}))
-        r.GET("/swarming/prod/:id", basemw, settings.Wrap(swarming.Build{}))
+        r.GET("/swarming/task/:id/steps/*logname", basemw,
+                settings.Wrap(swarming.LogHandler, "log.html"))
+        r.GET("/swarming/task/:id", basemw, settings.Wrap(
+                swarming.BuildHandler, "build.html"))
+        // Backward-compatible URLs for Swarming:
+        r.GET("/swarming/prod/:id/steps/*logname", basemw,
+                settings.Wrap(swarming.LogHandler, "log.html"))
+        r.GET("/swarming/prod/:id", basemw,
+                settings.Wrap(swarming.BuildHandler, "build.html"))
 
         // Buildbucket
-        r.GET("/buildbucket/:bucket/:builder", basemw, settings.Wrap(buildbucket.Builder{}))
+        r.GET("/buildbucket/:bucket/:builder", basemw,
+                settings.Wrap(buildbucket.BuilderHandler, "builder.html"))
 
         // Buildbot
-        r.GET("/buildbot/:master/:builder/:build", basemw, settings.Wrap(buildbot.Build{}))
-        r.GET("/buildbot/:master/:builder/", basemw, settings.Wrap(buildbot.Builder{}))
+        r.GET("/buildbot/:master/:builder/:build", basemw,
+                settings.Wrap(buildbot.BuildHandler, "build.html"))
+        r.GET("/buildbot/:master/:builder/", basemw,
+                settings.Wrap(buildbot.BuilderHandler, "builder.html"))
 
         // LogDog Milo Annotation Streams.
-        r.GET("/logdog/build/:project/*path", basemw, settings.Wrap(&logdog.AnnotationStreamHandler{}))
-
-        // User settings
-        r.GET("/settings", basemw, settings.Wrap(settings.Settings{}))
-        r.POST("/settings", basemw, settings.ChangeSettings)
+        r.GET("/logdog/build/:project/*prefix", basemw,
+                settings.Wrap(logdog.BuildHandler, "build.html"))
 
         // PubSub subscription endpoints.
         r.POST("/pubsub/buildbot", basemw, buildbot.PubSubHandler)
 
         // pRPC style endpoints.
         api := prpc.Server{
                 UnaryServerInterceptor: grpcmon.NewUnaryServerInterceptor(nil),
         }
         milo.RegisterBuildbotServer(&api, &milo.DecoratedBuildbot{
                 Service: &buildbot.Service{},
                 Prelude: emptyPrelude,
         })
         milo.RegisterBuildInfoServer(&api, &milo.DecoratedBuildInfo{
                 Service: &buildinfo.Service{},
                 Prelude: emptyPrelude,
         })
         discovery.Enable(&api)
         api.InstallHandlers(r, gaemiddleware.BaseProd())
 
         http.DefaultServeMux.Handle("/", r)
 }