Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: milo/appengine/buildbucket/html.go

Issue 2748073006: Milo Refactor: Remove theme support (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbucket/html.go
diff --git a/milo/appengine/buildbucket/html.go b/milo/appengine/buildbucket/html.go
index 9bfc5187a7799d611afd64d2c422d5203d182bf2..22a19f8563465fca3d45bc5d516c1c89067a276d 100644
--- a/milo/appengine/buildbucket/html.go
+++ b/milo/appengine/buildbucket/html.go
@@ -18,18 +18,10 @@ import (
// TODO(nodir): move this value to luci-config.
const defaultServer = "cr-buildbucket.appspot.com"
-// Builder displays builder view by fetching builds from buildbucket.
-type Builder struct{}
-
-// GetTemplateName for Builder returns the template name for builder pages.
-func (b Builder) GetTemplateName(t settings.Theme) string {
- return "builder.html"
-}
-
-// Render renders builder view page.
+// BuilderHandler renders the builder view page.
// Note: The builder html template contains self links to "?limit=123", which could
// potentially override any other request parameters set.
-func (b Builder) Render(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
+func BuilderHandler(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
// Parse URL parameters.
server := r.FormValue("server")
if server == "" {

Powered by Google App Engine
This is Rietveld 408576698