Run net_perftests on Linux perf bots

Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387, 730000
Review-Url: https://codereview.chromium.org/2748073003
Cr-Commit-Position: refs/heads/master@{#477715}
Committed: https://chromium.googlesource.com/chromium/src/+/bdefc4f71c8dd8dcd4b53d9adb2600c8574630bb

[xunjieli, 2017-03-14 16:10:36]

Description was changed from

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bost run net_perftests.

BUG=701387
==========

to

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387
==========

[xunjieli, 2017-03-14 16:10:47]

Patchset #1 (id:1) has been deleted

[xunjieli, 2017-03-14 16:14:49]

xunjieli@chromium.org changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2017-03-14 16:18:36]

eakuefner@chromium.org changed reviewers:
+ nednguyen@google.com
- eakuefner@chromium.org

[eakuefner, 2017-03-14 16:18:36]

+nednguyen, who should hopefully be an appropriate reviewer for this change.
Moving myself to bcc.

[nednguyen, 2017-03-14 17:33:29]

https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
tools/perf/generate_perf_json.py:468: ('net_perftests', 2),
You need to rebase, I think

[xunjieli, 2017-03-14 17:38:13]

Thanks, PTAL.

https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
tools/perf/generate_perf_json.py:468: ('net_perftests', 2),
On 2017/03/14 17:33:29, nednguyen wrote:
> You need to rebase, I think

Done.

[xunjieli, 2017-03-14 17:38:51]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-03-14 18:05:07]

On 2017/03/14 17:38:13, xunjieli wrote:
> Thanks, PTAL.
> 
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> File tools/perf/generate_perf_json.py (right):
> 
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> tools/perf/generate_perf_json.py:468: ('net_perftests', 2),
> On 2017/03/14 17:33:29, nednguyen wrote:
> > You need to rebase, I think
> 
> Done.

Can you tell me the runtime of the benchmark?  Also who should I put as the
benchmark owner?

[xunjieli, 2017-03-14 18:11:23]

On 2017/03/14 18:05:07, nednguyen wrote:
> On 2017/03/14 17:38:13, xunjieli wrote:
> > Thanks, PTAL.
> > 
> >
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> > File tools/perf/generate_perf_json.py (right):
> > 
> >
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> > tools/perf/generate_perf_json.py:468: ('net_perftests', 2),
> > On 2017/03/14 17:33:29, nednguyen wrote:
> > > You need to rebase, I think
> > 
> > Done.
> 
> Can you tell me the runtime of the benchmark?  Also who should I put as the
> benchmark owner?

I am not sure the runtime of these tests.  I think they must have been
accidentally dropped when bots were migrated.
You can put me (xunjieli@) as an owner for now until I figure out if we can
incorporate this into network triage rotation. 

These tests will be included:
      "base/mime_sniffer_perftest.cc",
      "cookies/cookie_monster_perftest.cc",
      "disk_cache/disk_cache_perftest.cc",
      "extras/sqlite/sqlite_persistent_cookie_store_perftest.cc",
      "proxy/proxy_resolver_perftest.cc",
      "socket/udp_socket_perftest.cc"

[nednguyen, 2017-03-14 18:18:24]

On 2017/03/14 18:11:23, xunjieli wrote:
> On 2017/03/14 18:05:07, nednguyen wrote:
> > On 2017/03/14 17:38:13, xunjieli wrote:
> > > Thanks, PTAL.
> > > 
> > >
> >
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> > > File tools/perf/generate_perf_json.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> > > tools/perf/generate_perf_json.py:468: ('net_perftests', 2),
> > > On 2017/03/14 17:33:29, nednguyen wrote:
> > > > You need to rebase, I think
> > > 
> > > Done.
> > 
> > Can you tell me the runtime of the benchmark?  Also who should I put as the
> > benchmark owner?
> 
> I am not sure the runtime of these tests.
  
Can you run the test locally to figure out? Sorry, just want to make sure the
runtime is reasonable (< 1 hour) :-)

> I think they must have been
> accidentally dropped when bots were migrated.
> You can put me (xunjieli@) as an owner for now until I figure out if we can
> incorporate this into network triage rotation. 
> 
> These tests will be included:
>       "base/mime_sniffer_perftest.cc",
>       "cookies/cookie_monster_perftest.cc",
>       "disk_cache/disk_cache_perftest.cc",
>       "extras/sqlite/sqlite_persistent_cookie_store_perftest.cc",
>       "proxy/proxy_resolver_perftest.cc",
>       "socket/udp_socket_perftest.cc"

[xunjieli, 2017-03-14 18:29:37]

On 2017/03/14 18:18:24, nednguyen wrote:
> On 2017/03/14 18:11:23, xunjieli wrote:
> > On 2017/03/14 18:05:07, nednguyen wrote:
> > > On 2017/03/14 17:38:13, xunjieli wrote:
> > > > Thanks, PTAL.
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> > > > File tools/perf/generate_perf_json.py (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2748073003/diff/20001/tools/perf/generate_per...
> > > > tools/perf/generate_perf_json.py:468: ('net_perftests', 2),
> > > > On 2017/03/14 17:33:29, nednguyen wrote:
> > > > > You need to rebase, I think
> > > > 
> > > > Done.
> > > 
> > > Can you tell me the runtime of the benchmark?  Also who should I put as
the
> > > benchmark owner?
> > 
> > I am not sure the runtime of these tests.
>   
> Can you run the test locally to figure out? Sorry, just want to make sure the
> runtime is reasonable (< 1 hour) :-)

Oh, okay. That's what you mean by runtime :)  They finish pretty fast -- 3min on
my Linux machine.


[==========] Running 21 tests from 8 test cases.
[----------] Global test environment set-up.
[----------] 1 test from MimeSnifferTest
[ RUN      ] MimeSnifferTest.PlainTextPerfTest
[25414:25414:0314/142555.938319:532340241097:INFO:mime_sniffer_perftest.cc(97)]
2601ns per KB
[       OK ] MimeSnifferTest.PlainTextPerfTest (22854 ms)
[----------] 1 test from MimeSnifferTest (22854 ms total)

[----------] 2 tests from ParsedCookieTest
[ RUN      ] ParsedCookieTest.TestParseCookies
Parsed_cookie_parse_cookies	687.273	ms
[       OK ] ParsedCookieTest.TestParseCookies (688 ms)
[ RUN      ] ParsedCookieTest.TestParseBigCookies
Parsed_cookie_parse_big_cookies	4905.84	ms
[       OK ] ParsedCookieTest.TestParseBigCookies (4906 ms)
[----------] 2 tests from ParsedCookieTest (5594 ms total)

[----------] 6 tests from CookieMonsterTest
[ RUN      ] CookieMonsterTest.TestAddCookiesOnSingleHost
Cookie_monster_add_single_host	3930.26	ms
Cookie_monster_query_single_host	29491.5	ms
Cookie_monster_deleteall_single_host	1.828	ms
[       OK ] CookieMonsterTest.TestAddCookiesOnSingleHost (33468 ms)
[ RUN      ] CookieMonsterTest.TestDomainTree
Cookie_monster_query_domain_tree	3567.01	ms
[       OK ] CookieMonsterTest.TestDomainTree (3573 ms)
[ RUN      ] CookieMonsterTest.TestDomainLine
Cookie_monster_query_domain_line	7166.27	ms
[       OK ] CookieMonsterTest.TestDomainLine (7172 ms)
[ RUN      ] CookieMonsterTest.TestImport
Cookie_monster_import_from_store	481.15	ms
[       OK ] CookieMonsterTest.TestImport (1664 ms)
[ RUN      ] CookieMonsterTest.TestGetKey
Cookie_monster_get_key	195.784	ms
[       OK ] CookieMonsterTest.TestGetKey (197 ms)
[ RUN      ] CookieMonsterTest.TestGCTimes
GC_all_recent	2155.4	ms
GC_mostly_recent	2234.31	ms
GC_balanced	2113.97	ms
GC_mostly_old	2002.66	ms
GC_less_than_gc_thresh	2109.65	ms
[       OK ] CookieMonsterTest.TestGCTimes (15183 ms)
[----------] 6 tests from CookieMonsterTest (61257 ms total)

[----------] 4 tests from DiskCachePerfTest
[ RUN      ] DiskCachePerfTest.BlockfileHashes
Hash disk cache keys	1616.09	ms
[       OK ] DiskCachePerfTest.BlockfileHashes (1620 ms)
[ RUN      ] DiskCachePerfTest.CacheBackendPerformance
Write disk cache entries	1207.58	ms
Read disk cache headers only (cold)	774.76	ms
Read disk cache headers only (warm)	772.568	ms
Read disk cache entries (cold)	3434.22	ms
Read disk cache entries (warm)	1075.5	ms
[       OK ] DiskCachePerfTest.CacheBackendPerformance (31174 ms)
[ RUN      ] DiskCachePerfTest.SimpleCacheBackendPerformance
Write disk cache entries	816.704	ms
Read disk cache headers only (cold)	6563.15	ms
Read disk cache headers only (warm)	633.432	ms
Read disk cache entries (cold)	6665.48	ms
Read disk cache entries (warm)	719.286	ms
[       OK ] DiskCachePerfTest.SimpleCacheBackendPerformance (41276 ms)
[ RUN      ] DiskCachePerfTest.BlockFilesPerformance
Fill three block-files	491.813	ms
Create and delete blocks	3365.66	ms
[       OK ] DiskCachePerfTest.BlockFilesPerformance (3867 ms)
[----------] 4 tests from DiskCachePerfTest (77937 ms total)

[----------] 2 tests from SQLitePersistentCookieStorePerfTest
[ RUN      ] SQLitePersistentCookieStorePerfTest.TestLoadForKeyPerformance
Load cookies for the eTLD+1 domain_0.com	32.82	ms
Load cookies for the eTLD+1 domain_1.com	1.577	ms
Load cookies for the eTLD+1 domain_2.com	2.805	ms
[       OK ] SQLitePersistentCookieStorePerfTest.TestLoadForKeyPerformance (2140
ms)
[ RUN      ] SQLitePersistentCookieStorePerfTest.TestLoadPerformance
Load all cookies	376.829	ms
[       OK ] SQLitePersistentCookieStorePerfTest.TestLoadPerformance (2513 ms)
[----------] 2 tests from SQLitePersistentCookieStorePerfTest (4653 ms total)

[----------] 1 test from ProxyResolverPerfTest
[ RUN      ] ProxyResolverPerfTest.ProxyResolverV8
ProxyResolverV8_no-ads.pac	246.504	ms
[       OK ] ProxyResolverPerfTest.ProxyResolverV8 (268 ms)
[----------] 1 test from ProxyResolverPerfTest (268 ms total)

[----------] 2 tests from UDPSocketPerfTest
[ RUN      ] UDPSocketPerfTest.Write
[25414:25414:0314/142828.049466:532492352206:INFO:udp_socket_perftest.cc(122)]
Write speed: 40.3932 MB/s
UDP_socket_write	2402.02	ms
[       OK ] UDPSocketPerfTest.Write (2402 ms)
[ RUN      ] UDPSocketPerfTest.WriteNonBlocking
[25414:25414:0314/142830.156434:532494459168:INFO:udp_socket_perftest.cc(122)]
Write speed: 46.0535 MB/s
UDP_socket_write_nonblocking	2106.69	ms
[       OK ] UDPSocketPerfTest.WriteNonBlocking (2107 ms)
[----------] 2 tests from UDPSocketPerfTest (4509 ms total)

[----------] 3 tests from WebSocketFrameTestMaskBenchmark
[ RUN      ] WebSocketFrameTestMaskBenchmark.BenchmarkMaskShortPayload
Frame_mask_short_payload	9.738	ms
[       OK ] WebSocketFrameTestMaskBenchmark.BenchmarkMaskShortPayload (10 ms)
[ RUN      ] WebSocketFrameTestMaskBenchmark.BenchmarkMaskLongPayload
Frame_mask_long_payload	847.571	ms
[       OK ] WebSocketFrameTestMaskBenchmark.BenchmarkMaskLongPayload (848 ms)
[ RUN      ] WebSocketFrameTestMaskBenchmark.Benchmark31BytePayload
Frame_mask_31_payload	12.734	ms
[       OK ] WebSocketFrameTestMaskBenchmark.Benchmark31BytePayload (13 ms)
[----------] 3 tests from WebSocketFrameTestMaskBenchmark (871 ms total)

[----------] Global test environment tear-down
[==========] 21 tests from 8 test cases ran. (177943 ms total)
[  PASSED  ] 21 tests.

  YOU HAVE 1 DISABLED TEST

> 
> > I think they must have been
> > accidentally dropped when bots were migrated.
> > You can put me (xunjieli@) as an owner for now until I figure out if we can
> > incorporate this into network triage rotation. 
> > 
> > These tests will be included:
> >       "base/mime_sniffer_perftest.cc",
> >       "cookies/cookie_monster_perftest.cc",
> >       "disk_cache/disk_cache_perftest.cc",
> >       "extras/sqlite/sqlite_persistent_cookie_store_perftest.cc",
> >       "proxy/proxy_resolver_perftest.cc",
> >       "socket/udp_socket_perftest.cc"

[commit-bot: I haz the power, 2017-03-14 18:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:47:34]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-03-14 19:02:59]

lgtm

[xunjieli, 2017-03-14 19:03:52]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 19:15:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xunjieli, 2017-03-14 19:18:38]

xunjieli@chromium.org changed reviewers:
+ dpranke@chromium.org

[xunjieli, 2017-03-14 19:18:39]

dpranke@: PTAL at testing/buildbot/gn_isolate_map.pyl. Thanks.

[Dirk Pranke, 2017-03-14 20:32:44]

lgtm

[xunjieli, 2017-03-14 20:35:30]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:36:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 20:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:48:46]

Failed to apply patch for tools/perf/generate_perf_json.py:
While running git apply --index -p1;
  error: tools/perf/generate_perf_json.py: does not exist in index

Patch:       tools/perf/generate_perf_json.py
Index: tools/perf/generate_perf_json.py
diff --git a/tools/perf/generate_perf_json.py b/tools/perf/generate_perf_json.py
index
6339808bd80bb530316a869c5097fd064a809500..2b3578bd4a364023c2bda5ea8ab841fbfe43b99e
100755
--- a/tools/perf/generate_perf_json.py
+++ b/tools/perf/generate_perf_json.py
@@ -465,6 +465,7 @@ def get_waterfall_config():
        'perf_tests': [
          # crbug.com/698831
          # ('cc_perftests', 2),
+         ('net_perftests', 2),
          ('load_library_perf_tests', 2),
          ('tracing_perftests', 2),
          ('media_perftests', 3)]

[xunjieli, 2017-03-14 20:55:21]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-03-14 20:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2748073003/#ps60001
(title: "rebased on to 5044aacd902c21b78c7811e4a608937dc630ab5c")

[commit-bot: I haz the power, 2017-03-14 20:56:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-03-14 21:01:00]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-03-14 21:07:02]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-03-14 21:07:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2748073003/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-14 21:08:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-03-14 21:18:33]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-03-14 21:49:57]

Description was changed from

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387
==========

to

==========
[ON HOLD] Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387
==========

[xunjieli, 2017-03-14 22:09:24]

I am putting this on hold. It might not be a good idea to enable these tests at
once. Some of them might be designed for one-off validations.
More details is at a net-dev@ thread:
https://groups.google.com/a/chromium.org/d/msg/net-dev/IQllSglbq38/CB0JBW9hEgAJ
I will start a new test target from scratch. Will update this email once that's
ready.

[xunjieli, 2017-06-06 19:11:50]

xunjieli@chromium.org changed reviewers:
+ mmenke@chromium.org

[xunjieli, 2017-06-06 19:11:50]

Matt: Can I put this on the bots? net_perftests isn't being run, which lead to
issues like crbug.com/730000.

I will handle any alerts from perf dashboard regarding this target.

[xunjieli, 2017-06-06 19:12:06]

Description was changed from

==========
[ON HOLD] Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387
==========

to

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387
==========

[xunjieli, 2017-06-06 19:12:46]

Description was changed from

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387
==========

to

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387, 730000
==========

[xunjieli, 2017-06-06 19:13:16]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 19:13:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 19:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 19:16:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-06-06 19:34:16]

On 2017/06/06 19:11:50, xunjieli wrote:
> Matt: Can I put this on the bots? net_perftests isn't being run, which lead to
> issues like crbug.com/730000.
> 
> I will handle any alerts from perf dashboard regarding this target.

I'm fine with it being run on the bots.

[mmenke, 2017-06-06 19:35:36]

On 2017/06/06 19:34:16, mmenke wrote:
> On 2017/06/06 19:11:50, xunjieli wrote:
> > Matt: Can I put this on the bots? net_perftests isn't being run, which lead
to
> > issues like crbug.com/730000.
> > 
> > I will handle any alerts from perf dashboard regarding this target.
> 
> I'm fine with it being run on the bots.

Though should check that none of the tests take an absurd amount of time

[xunjieli, 2017-06-06 19:45:57]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 19:46:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-06-06 19:59:46]

> > I'm fine with it being run on the bots.
> 
> Though should check that none of the tests take an absurd amount of time

Thanks. I checked in https://codereview.chromium.org/2748073003/#msg14. The
tests take ~3min on my linux machine.

Ned + Dirk: Please take a look at diff between PS#4 and PS#5.

[nednguyen, 2017-06-06 20:06:47]

On 2017/06/06 19:59:46, xunjieli wrote:
> > > I'm fine with it being run on the bots.
> > 
> > Though should check that none of the tests take an absurd amount of time
> 
> Thanks. I checked in https://codereview.chromium.org/2748073003/#msg14. The
> tests take ~3min on my linux machine.
> 
> Ned + Dirk: Please take a look at diff between PS#4 and PS#5.

lgtm

[commit-bot: I haz the power, 2017-06-06 21:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 21:26:51]

Dry run: This issue passed the CQ dry run.

[Maks Orlovich, 2017-06-07 13:36:58]

On 2017/06/06 20:06:47, nednguyen wrote:
> On 2017/06/06 19:59:46, xunjieli wrote:
> > > > I'm fine with it being run on the bots.
> > > 
> > > Though should check that none of the tests take an absurd amount of time
> > 
> > Thanks. I checked in https://codereview.chromium.org/2748073003/#msg14. The
> > tests take ~3min on my linux machine.
> > 
> > Ned + Dirk: Please take a look at diff between PS#4 and PS#5.
> 
> lgtm

As I am planning on changing one of the tests here at some point, may I ask what
effect on runtime would
still be considered reasonable?

[Dirk Pranke, 2017-06-07 16:52:08]

On 2017/06/07 13:36:58, Maks Orlovich wrote:
> On 2017/06/06 20:06:47, nednguyen wrote:
> > On 2017/06/06 19:59:46, xunjieli wrote:
> > > > > I'm fine with it being run on the bots.
> > > > 
> > > > Though should check that none of the tests take an absurd amount of time
> > > 
> > > Thanks. I checked in https://codereview.chromium.org/2748073003/#msg14.
The
> > > tests take ~3min on my linux machine.
> > > 
> > > Ned + Dirk: Please take a look at diff between PS#4 and PS#5.
> > 
> > lgtm
> 
> As I am planning on changing one of the tests here at some point, may I ask
what
> effect on runtime would
> still be considered reasonable?

There isn't a single clear rule for this at the moment, it depends on how
available the hardware in question is,
and how long the test time took previously. However, in the big pools, a change
of a few minutes or less i
s probably fine.

The change still lgtm.

[xunjieli, 2017-06-07 16:53:10]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-06-07 16:53:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 17:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 17:04:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xunjieli, 2017-06-07 17:09:29]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-06-07 17:09:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2748073003/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-07 17:10:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 18:59:05]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496855369552280,
"parent_rev": "19f44c261d415e22c208651a6bdf57092e08fc74", "commit_rev":
"bdefc4f71c8dd8dcd4b53d9adb2600c8574630bb"}

[commit-bot: I haz the power, 2017-06-07 18:59:15]

Description was changed from

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387, 730000
==========

to

==========
Run net_perftests on Linux perf bots

This CL makes Linux perf bots run net_perftests.

BUG=701387, 730000

Review-Url: https://codereview.chromium.org/2748073003
Cr-Commit-Position: refs/heads/master@{#477715}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdefc4f71c8dd8dcd4b53d9adb26...
==========

[commit-bot: I haz the power, 2017-06-07 18:59:18]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/bdefc4f71c8dd8dcd4b53d9adb26...