Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2748053004: [Offline Pages] Allow BackgroundLoader to track network bytes using prerenderer hook-in. (Closed)

Created:
3 years, 9 months ago by dewittj
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Allow BackgroundLoader to track network bytes using prerenderer hook-in. While this hook-in is less than ideal, allow us to unblock while architecting a better solution that will account for bytes, does not block net moving OOP, and at a rate frequent enough to be suitable. BUG=697695 Review-Url: https://codereview.chromium.org/2737343002 Cr-Commit-Position: refs/heads/master@{#457163} (cherry picked from commit f2fc623943d585acb44512ebafb626acd7b3f217) Review-Url: https://codereview.chromium.org/2748053004 . Cr-Commit-Position: refs/branch-heads/3029@{#217} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/4aab820ad80af5963d9531184bb0cd24a5029c9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5 lines) Patch
M chrome/browser/android/offline_pages/background_loader_offliner.h View 4 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 8 chunks +49 lines, -3 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc View 7 chunks +34 lines, -1 line 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
3 years, 9 months ago (2017-03-15 21:07:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4aab820ad80af5963d9531184bb0cd24a5029c9a.

Powered by Google App Engine
This is Rietveld 408576698