Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2748053002: Merge "[UserClassifier] Fix the classification for M58 condensed NTP..." (Closed)

Created:
3 years, 9 months ago by vitaliii
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge "[UserClassifier] Fix the classification for M58 condensed NTP..." This is a merge of https://codereview.chromium.org/2732243002 into M58 (branch 3029). There were no conflicts. === Original description === Previously, UserClassifier used suggestions impressions as activity signal. This breaks for condensed NTP when impressions are tied to opening an NTP. This CL replaces this signal by clicks. Clicks were previously recorded and not used. After this CL, impressions will stay being recorded. The reason is that with further changes in the UI, we may need it again. There is a TODO to remove this metric if not used. This CL also changes default values for activity metrics. The reason is to make sure that a new user is classified in the middle class. Lastly, the CL relaxes the thresholds. Currently, we have 67% rare, 33% active users, 1% active consumers. The aim is to move closer towards 55% / 40% / 5%. BUG=699021 Review-Url: https://codereview.chromium.org/2732243002 Cr-Commit-Position: refs/heads/master@{#455734} (cherry picked from commit f215f20a3eba699ac39d8bc5c0e4cf8e0d9b0610) Review-Url: https://codereview.chromium.org/2748053002 . Cr-Commit-Position: refs/branch-heads/3029@{#183} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/5b1922716b0af3cb32f16d329d0cbc131b25c46a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M components/ntp_snippets/user_classifier.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/ntp_snippets/user_classifier.cc View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vitaliii
3 years, 9 months ago (2017-03-14 07:56:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b1922716b0af3cb32f16d329d0cbc131b25c46a.

Powered by Google App Engine
This is Rietveld 408576698