Avoid EXPECT_EQ(false, _) in a chromeos unittest.

Avoid EXPECT_EQ(false, _) in a chromeos unittest.

EXPECT_EQ(false, _) is known to hit a GCC error, EXPECT_FALSE(_) is safer and
direct: https://github.com/google/googletest/issues/322#issuecomment-125645145.

It is causing compilation failure on the unittest inside simplechrome for some
boards. Well, probably nobody expect me may be doing that, but I still think it
is nicer to keep it compiling, as long as it can be done in a simple change.

BUG=none
TEST=`ninja chromeos_unittests` in simplechrome environment.

Review-Url: https://codereview.chromium.org/2748013002
Cr-Commit-Position: refs/heads/master@{#456624}
Committed: https://chromium.googlesource.com/chromium/src/+/df55352a0fb066e4bbf13dea774be63fd2d39aa9

[kinaba, 2017-03-14 04:31:36]

The CQ bit was checked by kinaba@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 04:31:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinaba, 2017-03-14 04:32:11]

kinaba@chromium.org changed reviewers:
+ rsorokin@chromium.org

[kinaba, 2017-03-14 04:32:11]

PTAL

[Roman Sorokin (ftl), 2017-03-14 04:35:03]

lgtm

[commit-bot: I haz the power, 2017-03-14 04:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 04:47:14]

Dry run: This issue passed the CQ dry run.

[kinaba, 2017-03-14 04:47:41]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2017-03-14 04:47:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 04:52:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489466861851800, "parent_rev":
"5c048822625c48c44e4e4336abc50c033ad8a251", "commit_rev":
"df55352a0fb066e4bbf13dea774be63fd2d39aa9"}

[commit-bot: I haz the power, 2017-03-14 04:53:35]

Description was changed from

==========
Avoid EXPECT_EQ(false, _) in a chromeos unittest.

EXPECT_EQ(false, _) is known to hit a GCC error, EXPECT_FALSE(_) is safer and
direct: https://github.com/google/googletest/issues/322#issuecomment-125645145.

It is causing compilation failure on the unittest inside simplechrome for some
boards. Well, probably nobody expect me may be doing that, but I still think it
is nicer to keep it compiling, as long as it can be done in a simple change.

BUG=none
TEST=`ninja chromeos_unittests` in simplechrome environment.
==========

to

==========
Avoid EXPECT_EQ(false, _) in a chromeos unittest.

EXPECT_EQ(false, _) is known to hit a GCC error, EXPECT_FALSE(_) is safer and
direct: https://github.com/google/googletest/issues/322#issuecomment-125645145.

It is causing compilation failure on the unittest inside simplechrome for some
boards. Well, probably nobody expect me may be doing that, but I still think it
is nicer to keep it compiling, as long as it can be done in a simple change.

BUG=none
TEST=`ninja chromeos_unittests` in simplechrome environment.

Review-Url: https://codereview.chromium.org/2748013002
Cr-Commit-Position: refs/heads/master@{#456624}
Committed:
https://chromium.googlesource.com/chromium/src/+/df55352a0fb066e4bbf13dea774b...
==========

[commit-bot: I haz the power, 2017-03-14 04:53:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df55352a0fb066e4bbf13dea774b...