Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2747943005: [InputEvent] Support 'insertTranspose' (Closed)

Created:
3 years, 9 months ago by chongz
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Support 'insertTranspose' This CL adds input type 'insertTranspose' for macOS hotkey Ctrl-t. BUG=652401 Review-Url: https://codereview.chromium.org/2747943005 Cr-Commit-Position: refs/heads/master@{#457316} Committed: https://chromium.googlesource.com/chromium/src/+/ef8ab61bac3cd1a4d714fbc4c1b9e5a042df3422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-transpose.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +15 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
chongz
yosin@ PTAL, thanks!
3 years, 9 months ago (2017-03-15 02:59:40 UTC) #7
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-15 03:15:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747943005/1
3 years, 9 months ago (2017-03-15 03:15:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/385775)
3 years, 9 months ago (2017-03-15 03:23:56 UTC) #12
chongz
tkent@ PTAL at "InputEvent.h/cpp", thanks!
3 years, 9 months ago (2017-03-15 14:21:27 UTC) #14
tkent
lgtm
3 years, 9 months ago (2017-03-16 00:18:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747943005/1
3 years, 9 months ago (2017-03-16 00:36:22 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:20:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef8ab61bac3cd1a4d714fbc4c1b9...

Powered by Google App Engine
This is Rietveld 408576698