[Web Payments] Add the shipping options sheet.

[Web Payments] Add the shipping options sheet.

BUG=700019
Review-Url: https://codereview.chromium.org/2747943004
Cr-Commit-Position: refs/heads/master@{#456913}
Committed: https://chromium.googlesource.com/chromium/src/+/eca2ac57012fdecf632d09b6220d7e45112e2e20

[anthonyvd, 2017-03-14 15:36:12]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-03-14 15:36:13]

Hi Math, this change lays the base for the shipping options sheet. It's a pretty
barebones implementation as it's our last list (yay!) and it's meant to inform a
bigger refactor of all list views (building on Tommy's).

Can you PTAL? Thanks!

[Mathieu, 2017-03-14 20:17:12]

Lgtm do we need to override ButtonPressed?

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:1527:
"views/payments/shipping_options_view_controller.cc",
mega nit warning!! we have payment_method_view_controller (not plural), so we
should have shipping_option_view_controller?

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/shipping_options_view_controller.cc
(right):

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/shipping_options_view_controller.cc:34:
payments::mojom::PaymentShippingOption* shipping_option_;
No need for payments::

[anthonyvd, 2017-03-14 20:26:16]

Thanks, removed the ButtonPressed override since it's indeed not needed.

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:1527:
"views/payments/shipping_options_view_controller.cc",
On 2017/03/14 at 20:17:11, Mathieu Perreault wrote:
> mega nit warning!! we have payment_method_view_controller (not plural), so we
should have shipping_option_view_controller?

Done!

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/shipping_options_view_controller.cc
(right):

https://codereview.chromium.org/2747943004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/shipping_options_view_controller.cc:34:
payments::mojom::PaymentShippingOption* shipping_option_;
On 2017/03/14 at 20:17:12, Mathieu Perreault wrote:
> No need for payments::

Done.

[anthonyvd, 2017-03-14 20:26:22]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-03-14 20:26:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2747943004/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-03-14 20:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 22:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:19:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-03-14 23:45:58]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:47:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:28:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489535158712760,
"parent_rev": "c4a2fb2a5af868924d3282721757194ded52374d", "commit_rev":
"eca2ac57012fdecf632d09b6220d7e45112e2e20"}

[commit-bot: I haz the power, 2017-03-15 00:28:50]

Description was changed from

==========
[Web Payments] Add the shipping options sheet.

BUG=700019
==========

to

==========
[Web Payments] Add the shipping options sheet.

BUG=700019

Review-Url: https://codereview.chromium.org/2747943004
Cr-Commit-Position: refs/heads/master@{#456913}
Committed:
https://chromium.googlesource.com/chromium/src/+/eca2ac57012fdecf632d09b6220d...
==========

[commit-bot: I haz the power, 2017-03-15 00:28:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eca2ac57012fdecf632d09b6220d...