Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2747943003: Remove media requesting code from StartPageService::StartPageWebContentsDelegate (Closed)

Created:
3 years, 9 months ago by raymes
Modified:
3 years, 9 months ago
Reviewers:
Jun Mukai, Matt Giuca
CC:
chromium-reviews, tfarina, Matt Giuca, chrome-apps-syd-reviews_chromium.org, xc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove media requesting code from StartPageService::StartPageWebContentsDelegate It looks like this code was added for the old hotwording extension which was removed. It's hard to tell how MediaStreamDevicesController::ReqestPermission would be working from this context if it was being used. BUG=596786 Review-Url: https://codereview.chromium.org/2747943003 Cr-Commit-Position: refs/heads/master@{#457351} Committed: https://chromium.googlesource.com/chromium/src/+/392df422aa3725fa4493b7453caeda569b70118a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
raymes
mukai@ does this seem reasonable to you? It doesn't feel like this code is still ...
3 years, 9 months ago (2017-03-14 04:30:48 UTC) #4
Jun Mukai
lgtm
3 years, 9 months ago (2017-03-14 17:22:31 UTC) #7
raymes
+mgiuca for OWNERS
3 years, 9 months ago (2017-03-15 00:25:11 UTC) #9
Matt Giuca
lgtm
3 years, 9 months ago (2017-03-16 04:02:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747943003/1
3 years, 9 months ago (2017-03-16 04:02:49 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 04:37:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/392df422aa3725fa4493b7453cae...

Powered by Google App Engine
This is Rietveld 408576698