Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2747933002: Make ResourceTimingInfo RefCounted. (Closed)

Created:
3 years, 9 months ago by sunjian
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ResourceTimingInfo RefCounted. Currently, ResourceTimingInfo's creation only returns a std::unique_ptr. However, a ref-counted ResourceTimingInfo instance is needed so that a single instance can be shared by multiple owners. The reason that this new feature is requested is because now we expose PerformanceNavigationTiming in a timely manner, which entails dynamically updating PerformanceNavigationTiming instance as more information gets collected. One ResourceTimingInfo instance will be held by a ResourceFether and a PerformanceNavigationTiming instance at the same time. ResourceFether will keep updating ResourceTimingInfo while PerformanceNavigationTiming consumes it. Therefore, making ResourceTimingInfo ref-counted is needed. BUG=701113 Review-Url: https://codereview.chromium.org/2747933002 Cr-Commit-Position: refs/heads/master@{#456865} Committed: https://chromium.googlesource.com/chromium/src/+/2e016fcf6b3eae31983727f7f768d7a9b841ecf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceTimingInfo.h View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
sunjian
The patch is separated out from https://codereview.chromium.org/2647643004/. Please take a look!
3 years, 9 months ago (2017-03-13 21:44:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747933002/1
3 years, 9 months ago (2017-03-13 21:45:22 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-13 21:45:24 UTC) #8
panicker
lgtm
3 years, 9 months ago (2017-03-13 22:44:30 UTC) #11
haraken
LGTM
3 years, 9 months ago (2017-03-14 03:06:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747933002/1
3 years, 9 months ago (2017-03-14 20:59:14 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:26:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e016fcf6b3eae31983727f7f768...

Powered by Google App Engine
This is Rietveld 408576698