Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2747923002: Fix crash entering VR with debug settings on to skip DON flow. (Closed)

Created:
3 years, 9 months ago by mthiesse
Modified:
3 years, 9 months ago
Reviewers:
bsheedy, cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash entering VR with debug settings on to skip DON flow. BUG=699220 Review-Url: https://codereview.chromium.org/2747923002 Cr-Commit-Position: refs/heads/master@{#456501} Committed: https://chromium.googlesource.com/chromium/src/+/b17535a3287b3a6e4b04e34106ee778736747312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mthiesse
PTAL
3 years, 9 months ago (2017-03-13 21:06:21 UTC) #2
cjgrant
lgtm
3 years, 9 months ago (2017-03-13 21:08:24 UTC) #3
bsheedy
lgtm
3 years, 9 months ago (2017-03-13 21:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747923002/1
3 years, 9 months ago (2017-03-13 21:09:21 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:06:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b17535a3287b3a6e4b04e34106ee...

Powered by Google App Engine
This is Rietveld 408576698