Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2747903002:
Apply sanity check for accelerated rendering unconditionally. (Closed)
DescriptionApply sanity check for accelerated rendering unconditionally.
We want this check in production builds also, not just debug.
BUG=698643
Review-Url: https://codereview.chromium.org/2747903002
Cr-Commit-Position: refs/heads/master@{#456522}
Committed: https://chromium.googlesource.com/chromium/src/+/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482
Patch Set 1 #
Total comments: 2
Patch Set 2 : use NOTREACHED, rephrase comment #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Apply sanity check for accelerated rendering unconditionally. We want this check in production builds also, not just debug. BUG=698643 ========== to ========== Apply sanity check for accelerated rendering unconditionally. We want this check in production builds also, not just debug. BUG=698643 ==========
klausw@chromium.org changed reviewers: + ddorwin@chromium.org
ddorwin@chromium.org changed reviewers: + bajones@chromium.org
Thanks. LGTM with question. https://codereview.chromium.org/2747903002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/vr/VRDisplay.cpp (right): https://codereview.chromium.org/2747903002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/vr/VRDisplay.cpp:564: // could implement an alternate slow path here for tests if How/when will we know?
https://codereview.chromium.org/2747903002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/vr/VRDisplay.cpp (right): https://codereview.chromium.org/2747903002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/vr/VRDisplay.cpp:564: // could implement an alternate slow path here for tests if On 2017/03/13 20:05:38, ddorwin wrote: > How/when will we know? Symptom would be the eye views staying black with no rendered content while presenting. AFAIK it's usual to keep sanity check errors to DLOG to avoid excessive strings being added. This path shouldn't get hit on any real hardware as far as I know, not sure if it would get activated on emulators or if running with "use hardware acceleration when available" disabled or equivalent. I didn't see a way to turn that off on my Android device to confirm.
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
LGTM
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by klausw@chromium.org
The CQ bit was checked by klausw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org, ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/2747903002/#ps20001 (title: "use NOTREACHED, rephrase comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489439974091040,
"parent_rev": "98e6d4474ac2dbe5ff3305c47833c241fa937a42", "commit_rev":
"35940a6d7e30f4aa3de61eb5dc6a3caace1a1482"}
Message was sent while issue was closed.
Description was changed from ========== Apply sanity check for accelerated rendering unconditionally. We want this check in production builds also, not just debug. BUG=698643 ========== to ========== Apply sanity check for accelerated rendering unconditionally. We want this check in production builds also, not just debug. BUG=698643 Review-Url: https://codereview.chromium.org/2747903002 Cr-Commit-Position: refs/heads/master@{#456522} Committed: https://chromium.googlesource.com/chromium/src/+/35940a6d7e30f4aa3de61eb5dc6a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/35940a6d7e30f4aa3de61eb5dc6a... |
