Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2747863005: Align IDL for navigator.cookieEnabled with spec (Closed)

Created:
3 years, 9 months ago by jsbell
Modified:
3 years, 9 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align IDL for navigator.cookieEnabled with spec NavigatorStorageUtils should be NavigatorCookies per [HTML] No behavior change - just renaming the IDL type which is [NoInterfaceObject] on a partial interface, so not visible to script. Spec: https://html.spec.whatwg.org/multipage/webappapis.html#cookies BUG=701472 Review-Url: https://codereview.chromium.org/2747863005 Cr-Commit-Position: refs/heads/master@{#457070} Committed: https://chromium.googlesource.com/chromium/src/+/0b4c5c0569ed07445c3e6e785567db8ed500977c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.idl View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/frame/NavigatorCookies.idl View 1 chunk +10 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/frame/NavigatorStorageUtils.idl View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jsbell
foolip@ - can you please review? (and cq if lg?)
3 years, 9 months ago (2017-03-14 20:24:00 UTC) #4
foolip
lgtm
3 years, 9 months ago (2017-03-15 13:37:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747863005/1
3 years, 9 months ago (2017-03-15 13:38:14 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 13:44:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b4c5c0569ed07445c3e6e785567...

Powered by Google App Engine
This is Rietveld 408576698