Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2747853002: Rename xFunctionBody to xBlockFunctionBody. Document related listener methods. (Closed)
Patch Set: Rename to handleEmptyFunctionBody() and handleExpressionFunctionBody(). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 65f324a8ba4f63c6f4176187e1f10a29838bc4ec..b403485cf958f7ff926a4da6fb66f1e08f8fcba9 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -350,8 +350,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
}
@override
- void endFunctionBody(int count, Token beginToken, Token endToken) {
- debugEvent("FunctionBody");
+ void endBlockFunctionBody(int count, Token beginToken, Token endToken) {
+ debugEvent("BlockFunctionBody");
if (beginToken == null) {
assert(count == 0);
push(NullValue.Block);
@@ -869,13 +869,13 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
}
@override
- void endEmptyFunctionBody(Token semicolon) {
+ void handleEmptyFunctionBody(Token semicolon) {
debugEvent("ExpressionFunctionBody");
- endFunctionBody(0, null, semicolon);
+ endBlockFunctionBody(0, null, semicolon);
}
@override
- void endExpressionFunctionBody(Token arrowToken, Token endToken) {
+ void handleExpressionFunctionBody(Token arrowToken, Token endToken) {
debugEvent("ExpressionFunctionBody");
endReturnStatement(true, arrowToken, endToken);
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart ('k') | pkg/front_end/lib/src/fasta/parser/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698