Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

Issue 2747853002: Rename xFunctionBody to xBlockFunctionBody. Document related listener methods. (Closed)
Patch Set: Rename to handleEmptyFunctionBody() and handleExpressionFunctionBody(). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
index f56e5b78c4228104684e63b43c0f566c59241484..68f28a049251ef0f1592fe93f6fbaae3e3ab6795 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
@@ -235,7 +235,7 @@ class AstBuilder extends ScopeListener {
}
@override
- void endEmptyFunctionBody(Token semicolon) {
+ void handleEmptyFunctionBody(Token semicolon) {
debugEvent("EmptyFunctionBody");
// TODO(scheglov) Change the parser to not produce these modifiers.
pop(); // star
@@ -243,8 +243,8 @@ class AstBuilder extends ScopeListener {
push(ast.emptyFunctionBody(toAnalyzerToken(semicolon)));
}
- void endFunctionBody(int count, Token beginToken, Token endToken) {
- debugEvent("FunctionBody");
+ void endBlockFunctionBody(int count, Token beginToken, Token endToken) {
+ debugEvent("BlockFunctionBody");
List statements = popList(count);
if (beginToken != null) {
exitLocalScope();
@@ -347,7 +347,7 @@ class AstBuilder extends ScopeListener {
push(ast.integerLiteral(toAnalyzerToken(token), int.parse(token.lexeme)));
}
- void endExpressionFunctionBody(Token arrowToken, Token endToken) {
+ void handleExpressionFunctionBody(Token arrowToken, Token endToken) {
debugEvent("ExpressionFunctionBody");
Expression expression = pop();
analyzer.Token star = pop();
« no previous file with comments | « pkg/compiler/lib/src/parser/node_listener.dart ('k') | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698