Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2747833003: MD Bookmarks: Show pointer cursor on entire bookmark item. (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Show pointer cursor on entire bookmark item. The whole <bookmark-item> element is clickable, but the pointer cursor was set to only appear on the bookmark title text. This also affects the touchscreen tap highlight. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2747833003 Cr-Commit-Position: refs/heads/master@{#456861} Committed: https://chromium.googlesource.com/chromium/src/+/40f48059f7f123778ac5ae4a746968f60f174f4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/md_bookmarks/item.html View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tsergeant
And now for something on the opposite side of the CL size spectrum
3 years, 9 months ago (2017-03-14 06:40:37 UTC) #5
calamity
Quick LGTM.
3 years, 9 months ago (2017-03-14 07:00:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747833003/1
3 years, 9 months ago (2017-03-14 22:07:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:17:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40f48059f7f123778ac5ae4a7469...

Powered by Google App Engine
This is Rietveld 408576698