Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2747823004: Fix QueryCounter on a pending query (Closed)

Created:
3 years, 9 months ago by piman
Modified:
3 years, 9 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix QueryCounter on a pending query BUG=699481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2747823004 Cr-Commit-Position: refs/heads/master@{#456753} Committed: https://chromium.googlesource.com/chromium/src/+/bbd052efa719a473ee143cdb8f6e84bcbfbf0876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M gpu/command_buffer/service/query_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M ui/gl/gpu_timing_fake.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
piman
3 years, 9 months ago (2017-03-13 21:16:39 UTC) #4
Zhenyao Mo
On 2017/03/13 21:16:39, piman wrote: lgtm
3 years, 9 months ago (2017-03-14 17:14:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747823004/1
3 years, 9 months ago (2017-03-14 17:30:08 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 17:37:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bbd052efa719a473ee143cdb8f6e...

Powered by Google App Engine
This is Rietveld 408576698