Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2747813006: Make Bluetooth#requestDevice argument options optional (Closed)

Created:
3 years, 9 months ago by lunalu1
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, haraken, blink-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Bluetooth#requestDevice argument options optional Tests written in: https://github.com/w3c/web-platform-tests/pull/5219 BUG=701562 Review-Url: https://codereview.chromium.org/2747813006 Cr-Commit-Position: refs/heads/master@{#460147} Committed: https://chromium.googlesource.com/chromium/src/+/9b57404e044390a87a0f9967c476e1ae46611a9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
lunalu1
PTAL
3 years, 9 months ago (2017-03-16 01:02:22 UTC) #6
foolip
This will affect Bluetooth.prototype.requestDevice.length, can you add a test in https://github.com/w3c/web-platform-tests/tree/master/bluetooth?
3 years, 9 months ago (2017-03-21 07:50:17 UTC) #7
lunalu1
https://github.com/w3c/web-platform-tests/pull/5219
3 years, 9 months ago (2017-03-24 14:56:21 UTC) #8
foolip
On 2017/03/24 14:56:21, loonybear wrote: > https://github.com/w3c/web-platform-tests/pull/5219 Oh, external/wpt/bluetooth isn't imported yet. That's annoying. This ...
3 years, 8 months ago (2017-03-28 13:24:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747813006/1
3 years, 8 months ago (2017-03-28 14:20:47 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:17:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b57404e044390a87a0f9967c476...

Powered by Google App Engine
This is Rietveld 408576698