Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2747763002: Add use count for click retargeting due to capture (Closed)

Created:
3 years, 9 months ago by Navid Zolghadr
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, dtapuska+blinkwatch_chromium.org, asvitkine+watch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use count for click retargeting due to capture Since pointer capture changes the target of the following events for that pointer it potentially changes the target of the click. Considering the changed target for calculating the click target may cause some websites to break. So this CL adds a usecount for that case. Note this is an upper bound on the breakage as lots of pages may not have any listener for these click events or just not break due to this retargetting. BUG=699933 Review-Url: https://codereview.chromium.org/2747763002 Cr-Commit-Position: refs/heads/master@{#456933} Committed: https://chromium.googlesource.com/chromium/src/+/18a3165ddb7326845a6028b1e3f93f7d347bde95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Navid Zolghadr
3 years, 9 months ago (2017-03-13 14:46:05 UTC) #4
mustaq
lgtm
3 years, 9 months ago (2017-03-13 14:55:42 UTC) #5
Navid Zolghadr
bokan@ could you please review the changes under: third_party/WebKit/Source/core/*
3 years, 9 months ago (2017-03-13 19:19:15 UTC) #9
Navid Zolghadr
holte@ could you please the changed in: tools/metrics/histograms/histograms.xml
3 years, 9 months ago (2017-03-13 19:22:01 UTC) #11
bokan
rs lgtm based on Mustaq's review.
3 years, 9 months ago (2017-03-13 21:29:05 UTC) #12
Steven Holte
histograms lgtm
3 years, 9 months ago (2017-03-14 22:21:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747763002/1
3 years, 9 months ago (2017-03-14 22:39:34 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 01:11:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18a3165ddb7326845a6028b1e3f9...

Powered by Google App Engine
This is Rietveld 408576698