Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2747733002: [test] remove unnecessary whitelisted builtins from test-debug.cc (Closed)

Created:
3 years, 9 months ago by caitp
Modified:
3 years, 9 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] remove unnecessary whitelisted builtins from test-debug.cc BUG=chromium:691875 R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2747733002 Cr-Commit-Position: refs/heads/master@{#43800} Committed: https://chromium.googlesource.com/v8/v8/+/e08289d0edb3f36ec5abdef36984c080c51c30e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M test/cctest/test-debug.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
caitp
PTAL --- Meant to submit this with Gerrit, oops.
3 years, 9 months ago (2017-03-13 12:23:34 UTC) #1
gsathya
lgtm
3 years, 9 months ago (2017-03-13 17:55:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747733002/1
3 years, 9 months ago (2017-03-14 16:36:52 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 17:02:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e08289d0edb3f36ec5abdef36984c080c51...

Powered by Google App Engine
This is Rietveld 408576698