Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 274773003: Allow MakeCriticalClosure to enclose closures with non-void return types. (Closed)

Created:
6 years, 7 months ago by gab
Modified:
6 years, 7 months ago
Reviewers:
stuartmorgan, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, robertshield
Visibility:
Public.

Description

Allow MakeCriticalClosure to enclose closures with non-void return types. This is required in order to allow ImportantFileWriter::WriteFileAtomically() to report its bool result to the calling thread via PostTaskAndReplyWithResult() in https://codereview.chromium.org/257003007/ BUG=365769 R=stuartmorgan@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -57 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M base/critical_closure.h View 2 chunks +48 lines, -5 lines 0 comments Download
A base/critical_closure_internal_ios.mm View 1 chunk +17 lines, -0 lines 0 comments Download
D base/critical_closure_ios.mm View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gab
Nico/Stuart PTAL, split off from https://codereview.chromium.org/257003007/ as requested.
6 years, 7 months ago (2014-05-07 23:39:49 UTC) #1
Nico
this lgtm if Stuart likes it.
6 years, 7 months ago (2014-05-07 23:59:23 UTC) #2
gab
On 2014/05/07 23:59:23, Nico wrote: > this lgtm if Stuart likes it. Thanks, Stuart please ...
6 years, 7 months ago (2014-05-08 02:49:45 UTC) #3
stuartmorgan
The inlining due to the templates makes me sad, since this makes the header really ...
6 years, 7 months ago (2014-05-08 16:55:28 UTC) #4
gab
The CQ bit was checked by gab@chromium.org
6 years, 7 months ago (2014-05-08 16:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/274773003/1
6 years, 7 months ago (2014-05-08 17:00:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 21:05:50 UTC) #7
gab
6 years, 7 months ago (2014-05-09 11:58:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r269238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698