Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: base/critical_closure.h

Issue 274773003: Allow MakeCriticalClosure to enclose closures with non-void return types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/base.gypi ('k') | base/critical_closure_internal_ios.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_CRITICAL_CLOSURE_H_ 5 #ifndef BASE_CRITICAL_CLOSURE_H_
6 #define BASE_CRITICAL_CLOSURE_H_ 6 #define BASE_CRITICAL_CLOSURE_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 9
10 #if defined(OS_IOS)
11 #include "base/bind.h"
12 #include "base/ios/scoped_critical_action.h"
13 #endif
14
10 namespace base { 15 namespace base {
11 16
12 // Returns a closure that will continue to run for a period of time when the 17 namespace internal {
18
19 #if defined(OS_IOS)
20 // Returns true if multi-tasking is supported on this iOS device.
21 bool IsMultiTaskingSupported();
22
23 // This class wraps a closure so it can continue to run for a period of time
24 // when the application goes to the background by using
25 // |ios::ScopedCriticalAction|.
26 template <typename R>
27 class CriticalClosure {
28 public:
29 explicit CriticalClosure(const Callback<R(void)>& closure)
30 : closure_(closure) {}
31
32 ~CriticalClosure() {}
33
34 R Run() {
35 return closure_.Run();
36 }
37
38 private:
39 ios::ScopedCriticalAction critical_action_;
40 Callback<R(void)> closure_;
41
42 DISALLOW_COPY_AND_ASSIGN(CriticalClosure);
43 };
44 #endif // defined(OS_IOS)
45
46 } // namespace internal
47
48 // Returns a closure (which may return a result, but must not require any extra
49 // arguments) that will continue to run for a period of time when the
13 // application goes to the background if possible on platforms where 50 // application goes to the background if possible on platforms where
14 // applications don't execute while backgrounded, otherwise the original task is 51 // applications don't execute while backgrounded, otherwise the original task is
15 // returned. 52 // returned.
16 // 53 //
17 // Example: 54 // Example:
18 // file_message_loop_proxy_->PostTask( 55 // file_message_loop_proxy_->PostTask(
19 // FROM_HERE, 56 // FROM_HERE,
20 // MakeCriticalClosure(base::Bind(&WriteToDiskTask, path_, data))); 57 // MakeCriticalClosure(base::Bind(&WriteToDiskTask, path_, data)));
21 // 58 //
22 // Note new closures might be posted in this closure. If the new closures need 59 // Note new closures might be posted in this closure. If the new closures need
23 // background running time, |MakeCriticalClosure| should be applied on them 60 // background running time, |MakeCriticalClosure| should be applied on them
24 // before posting. 61 // before posting.
25 #if defined(OS_IOS) 62 #if defined(OS_IOS)
26 base::Closure MakeCriticalClosure(const base::Closure& closure); 63 template <typename R>
27 #else 64 Callback<R(void)> MakeCriticalClosure(const Callback<R(void)>& closure) {
28 inline base::Closure MakeCriticalClosure(const base::Closure& closure) { 65 DCHECK(internal::IsMultiTaskingSupported());
66 return base::Bind(&internal::CriticalClosure<R>::Run,
67 Owned(new internal::CriticalClosure<R>(closure)));
68 }
69 #else // defined(OS_IOS)
70 template <typename R>
71 inline Callback<R(void)> MakeCriticalClosure(const Callback<R(void)>& closure) {
29 // No-op for platforms where the application does not need to acquire 72 // No-op for platforms where the application does not need to acquire
30 // background time for closures to finish when it goes into the background. 73 // background time for closures to finish when it goes into the background.
31 return closure; 74 return closure;
32 } 75 }
33 #endif // !defined(OS_IOS) 76 #endif // defined(OS_IOS)
34 77
35 } // namespace base 78 } // namespace base
36 79
37 #endif // BASE_CRITICAL_CLOSURE_H_ 80 #endif // BASE_CRITICAL_CLOSURE_H_
OLDNEW
« no previous file with comments | « base/base.gypi ('k') | base/critical_closure_internal_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698