Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2747723004: Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.c… (Closed)

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
oshima, Bret, sadrul
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ ) Reason for revert: Breaking M57 crbug/698627 Original issue's description: > Correctly update the popup window position > > It was updating the child window instead. > This CL hooks up the bounds change to the desktop widget correctly. > > BUG=612270 > TEST=fixed test harness to do the correct check. > > Review-Url: https://codereview.chromium.org/2583873002 > Cr-Commit-Position: refs/heads/master@{#442741} > Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org BUG=612270, 698627 Review-Url: https://codereview.chromium.org/2728293004 Cr-Commit-Position: refs/heads/master@{#455231} (cherry picked from commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a) Review-Url: https://codereview.chromium.org/2747723004 . Cr-Commit-Position: refs/branch-heads/3029@{#159} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -69 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 7 chunks +4 lines, -23 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
3 years, 9 months ago (2017-03-13 18:56:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3.

Powered by Google App Engine
This is Rietveld 408576698