Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2747723002: Fix .so-file enumeration in generate_gradle.py. (Closed)

Created:
3 years, 9 months ago by sakal-chromium
Modified:
3 years, 9 months ago
Reviewers:
Peter Wen, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix .so-file enumeration in generate_gradle.py. BUG=620034, webrtc:6328 NOTRY=True Review-Url: https://codereview.chromium.org/2747723002 Cr-Commit-Position: refs/heads/master@{#456373} Committed: https://chromium.googlesource.com/chromium/src/+/8a4451c911ee05e56000474c58bfad89f744a35e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gradle/generate_gradle.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal-chromium
PTAL
3 years, 9 months ago (2017-03-13 11:42:26 UTC) #2
Peter Wen
lgtm
3 years, 9 months ago (2017-03-13 12:51:33 UTC) #5
agrieve
On 2017/03/13 12:51:33, Peter Wen wrote: > lgtm lgtm
3 years, 9 months ago (2017-03-13 14:21:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747723002/1
3 years, 9 months ago (2017-03-13 14:21:52 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 14:27:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a4451c911ee05e56000474c58bf...

Powered by Google App Engine
This is Rietveld 408576698