Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 2747713002: Reenable HistoryEntryInserterTest.AddSections. (Closed)

Created:
3 years, 9 months ago by lpromero
Modified:
3 years, 9 months ago
Reviewers:
gambard
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable HistoryEntryInserterTest.AddSections. The test added history entries at 1am the day of the test, the day before and 2 days before and expects the three to appear in different sections. With DST, 48hours before was still the same day as 24h ago. This test would have turned green tomorrow, but now that it is moved to middays, we shouldn't run in the issue again next time. BUG=700814 R=gambard@chromium.org Review-Url: https://codereview.chromium.org/2747713002 Cr-Commit-Position: refs/heads/master@{#456356} Committed: https://chromium.googlesource.com/chromium/src/+/88543c5651a7509cf1d39370504a597081b240e9

Patch Set 1 #

Patch Set 2 : Move the history timestamp one hour later. #

Patch Set 3 : Move to midday to avoid daylight savings time shifts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
lpromero
3 years, 9 months ago (2017-03-13 12:10:58 UTC) #9
gambard
lgtm but can you edit your description to explain the change?
3 years, 9 months ago (2017-03-13 12:12:56 UTC) #10
lpromero
On 2017/03/13 12:12:56, gambard wrote: > lgtm but can you edit your description to explain ...
3 years, 9 months ago (2017-03-13 12:13:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747713002/40001
3 years, 9 months ago (2017-03-13 12:40:57 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 12:45:10 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/88543c5651a7509cf1d39370504a...

Powered by Google App Engine
This is Rietveld 408576698