Add missing include guards in Cocoa code.

Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the initial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \
    BEGIN { \
      toprint = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (NR == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604
Review-Url: https://codereview.chromium.org/2747693003
Cr-Commit-Position: refs/heads/master@{#456628}
Committed: https://chromium.googlesource.com/chromium/src/+/81c5524dfe7a67cb4fc12026ffc9e5f87b13167d

[dominickn, 2017-03-14 04:22:08]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 04:22:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-14 04:23:10]

dominickn@chromium.org changed reviewers:
+ tapted@chromium.org

[dominickn, 2017-03-14 04:23:11]

PTAL, thanks!

[dominickn, 2017-03-14 04:33:14]

Description was changed from

==========
Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the intial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" | xargs -n1 awk ' \
    BEGIN { \
      toprint = 0; \
      i = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (i == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604
==========

to

==========
Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the intial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \
    BEGIN { \
      toprint = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (NR == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604
==========

[commit-bot: I haz the power, 2017-03-14 04:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 04:43:07]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-03-14 04:45:48]

lgtm with the following

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h (right):

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h:13: // dragging from
moving the browser window.
move down to above BookmarkBarView

[dominickn, 2017-03-14 05:03:12]

Thanks!

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h (right):

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h:13: // dragging from
moving the browser window.
On 2017/03/14 04:45:48, tapted wrote:
> move down to above BookmarkBarView

Done.

[dominickn, 2017-03-14 05:03:33]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-03-14 05:03:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2747693003/#ps20001
(title: "Fix nit")

[commit-bot: I haz the power, 2017-03-14 05:03:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-14 05:12:05]

Description was changed from

==========
Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the intial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \
    BEGIN { \
      toprint = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (NR == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604
==========

to

==========
Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the initial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \
    BEGIN { \
      toprint = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (NR == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604
==========

[commit-bot: I haz the power, 2017-03-14 05:24:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489467813387520,
"parent_rev": "1715d063f1f9978f154bfef8a529717ec8c39702", "commit_rev":
"81c5524dfe7a67cb4fc12026ffc9e5f87b13167d"}

[commit-bot: I haz the power, 2017-03-14 05:25:46]

Description was changed from

==========
Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the initial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \
    BEGIN { \
      toprint = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (NR == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604
==========

to

==========
Add missing include guards in Cocoa code.

This CL adds the usual Chromium include guard to Cocoa files which are
missing it. It also moves comments in some files to ensure that the
guard is consistently placed as the first lines after the initial license
text in each header.

The files were found by running the following shell script:

find chrome/browser/ui/cocoa/ -name "*.h" -print0 | xargs -n1 -0 awk ' \
    BEGIN { \
      toprint = 0; \
    } { \
      if ($0 ~ /^.ifndef/) { \
        toprint = 1; \
        exit 0; \
      } else if (NR == 5) { \
        exit 0; \
      } \
    } END { \
      if (toprint == 0) { \
        print FILENAME; \
      } \
    }'

BUG=700604

Review-Url: https://codereview.chromium.org/2747693003
Cr-Commit-Position: refs/heads/master@{#456628}
Committed:
https://chromium.googlesource.com/chromium/src/+/81c5524dfe7a67cb4fc12026ffc9...
==========

[commit-bot: I haz the power, 2017-03-14 05:25:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81c5524dfe7a67cb4fc12026ffc9...

[tapted, 2017-03-14 05:51:48]

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h (right):

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h:13: // dragging from
moving the browser window.
On 2017/03/14 05:03:12, dominickn wrote:
> On 2017/03/14 04:45:48, tapted wrote:
> > move down to above BookmarkBarView
> 
> Done.

you moved it too far ;)

It doesn't belong above "BookmarkBarView()", but "BookmarkBarView" - just a
couple of lines down from where it was above a forward-declare for
BookmarkBarController

[dominickn, 2017-03-14 05:56:02]

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h (right):

https://codereview.chromium.org/2747693003/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h:13: // dragging from
moving the browser window.
On 2017/03/14 05:51:47, tapted wrote:
> On 2017/03/14 05:03:12, dominickn wrote:
> > On 2017/03/14 04:45:48, tapted wrote:
> > > move down to above BookmarkBarView
> > 
> > Done.
> 
> you moved it too far ;)
> 
> It doesn't belong above "BookmarkBarView()", but "BookmarkBarView" - just a
> couple of lines down from where it was above a forward-declare for
> BookmarkBarController

Ugh, that's a vision fail. Sending you a follow up to fix.