Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(295)

Issue 2747653002: Use depfiles for mojom generation. (Closed)

Created:
11 months, 1 week ago by Sam McNally
Modified:
11 months, 1 week ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use depfiles for mojom generation. Currently, if foo.mojom imports bar.mojom and bar.mojom changes, foo.mojom will not be regenerated. If the change to bar.mojom changes which traits headers should be included by foo.mojom.cc by adding or removing a typemapped type, this can cause compile failures. This CL fixes this by generating a depfile for each mojom generation step so changing any mojoms imported by a particular mojom cause the bindings for that mojom to be regenerated. BUG=652404 Review-Url: https://codereview.chromium.org/2747653002 Cr-Commit-Position: refs/heads/master@{#456513} Committed: https://chromium.googlesource.com/chromium/src/+/8e4878fdb12d295c90bbfe58adf3d87016561695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Sam McNally
11 months, 1 week ago (2017-03-13 05:58:19 UTC) #4
yzshen1
lgtm
11 months, 1 week ago (2017-03-13 17:01:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747653002/1
11 months, 1 week ago (2017-03-13 22:34:11 UTC) #13
commit-bot: I haz the power
11 months, 1 week ago (2017-03-13 22:46:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e4878fdb12d295c90bbfe58adf3...

Powered by Google App Engine
This is Rietveld 408576698