Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2747633002: Fixing a crash in MediaCustomControlsFullscreenDetector when the page is destroyed (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fixing a crash in MediaCustomControlsFullscreenDetector when the page is destroyed There's a situation that hits a DCHECK() in MediaCustomControlsFullscreenDetector when the video become fullscreen but the page navigates away before the timer fires. This CL solves the issue by stopping the timer when the ExecutionContext is destroyed. This CL also moves the common parts of MockWebMediaPlayer into EmptyWebMediaPlayer. There are still some other MockWebMediaPlayers which will be adopted in a follow-up. BUG=698034 Review-Url: https://codereview.chromium.org/2729613007 Cr-Commit-Position: refs/heads/master@{#455740} (cherry picked from commit fe180eb4effd53064142647a839b89d3910dfff0) Review-Url: https://codereview.chromium.org/2747633002 . Cr-Commit-Position: refs/branch-heads/3029@{#136} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7bb43d450f514993aa48475c759af3a072fa6038

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-12 18:34:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bb43d450f514993aa48475c759af3a072fa6038 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698