Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2747573002: Image Capture: MediaStreamTrack::getCapabilities() (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, mcasas+imagecapture_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: MediaStreamTrack::getCapabilities() This CL adds MediaTrackCapabilities.idl and MediaStreamTrack::getCapabilities(). The latter function is wired to grab the capabilities from image capture, since these are the only ones available ATM. These capabilities should only be collected for Video tracks from devices (i.e. not for tab/window/cast/remote etc). MediaStreamTrack.getCapabilities() is synchronous, whereas image_capture mojom::getPhotoCapabities() is not -- the former probably doesn't make a lot of sense Spec-wise but, regardless, I don't think is a good idea to make the Web thread wait for these capabilities to be collected, so what this CL does is to trigger such collection upon MediaStreamTrack ctor, without waiting for this process to be finished. (IOW I tried alternatives and were much worse). Added LayoutTests for starters. This bug is part of a transition from ImageCapture.getPhotoCapabilities() to MediaStreamTrack.getCapabilities() but, since Image Capture is already in Origin Trials, I'm planning on landing the new infra in parallel, then send a PSA and switch over (that's why there's a few TODOs) in the code. BUG=700607 Incidentally, it improves the state of external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html by allowing the test-for-getCapabilities() to PASS. Review-Url: https://codereview.chromium.org/2747573002 Cr-Commit-Position: refs/heads/master@{#457150} Committed: https://chromium.googlesource.com/chromium/src/+/30a67395e8cfccfd5954b9244440a7906d065563

Patch Set 1 : #

Total comments: 17

Patch Set 2 : haraken@ and reillyg@s comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -51 lines) Patch
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html View 1 chunk +139 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.h View 4 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 7 chunks +112 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 4 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +2 lines, -0 lines 1 comment Download
A third_party/WebKit/Source/modules/mediastream/MediaTrackCapabilities.idl View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
mcasas
reillyg@: PTAL at the imagecapture/ parts guidou@ PTAL the mediastream/ parts
3 years, 9 months ago (2017-03-14 18:39:10 UTC) #10
haraken
https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp#newcode323 third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:323: caps->setIso(MediaSettingsRange::create(std::move(capabilities->iso))); Why do we need to create a new ...
3 years, 9 months ago (2017-03-14 19:56:37 UTC) #13
Reilly Grant (use Gerrit)
lgtm with nits https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html File third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html (right): https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html#newcode10 third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html:10: // returns something. (Other tests go ...
3 years, 9 months ago (2017-03-14 21:38:57 UTC) #14
mcasas
haraken@ PTAL (guidou@ still ptal) https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html File third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html (right): https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html#newcode10 third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getCapabilities.html:10: // returns something. (Other ...
3 years, 9 months ago (2017-03-14 22:28:02 UTC) #18
haraken
https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp#newcode323 third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:323: caps->setIso(MediaSettingsRange::create(std::move(capabilities->iso))); On 2017/03/14 22:28:01, mcasas wrote: > On 2017/03/14 ...
3 years, 9 months ago (2017-03-15 08:43:09 UTC) #20
haraken
On 2017/03/15 08:43:09, haraken wrote: > https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp > File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): > > https://codereview.chromium.org/2747573002/diff/120001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp#newcode323 > ...
3 years, 9 months ago (2017-03-15 16:08:49 UTC) #21
Guido Urdaneta
mediastream lgtm, take a look at my question. https://codereview.chromium.org/2747573002/diff/200001/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl File third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl (right): https://codereview.chromium.org/2747573002/diff/200001/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl#newcode53 third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl:53: [RuntimeEnabled=ImageCapture] ...
3 years, 9 months ago (2017-03-15 17:04:19 UTC) #22
mcasas
On 2017/03/15 17:04:19, Guido Urdaneta wrote: > mediastream lgtm, take a look at my question. ...
3 years, 9 months ago (2017-03-15 17:20:29 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747573002/200001
3 years, 9 months ago (2017-03-15 17:21:55 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:51:15 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/30a67395e8cfccfd5954b9244440...

Powered by Google App Engine
This is Rietveld 408576698