Issue 2747563002: When navigation focuses a web contents, also activate its window.

Issue 2747563002: When navigation focuses a web contents, also activate its window. (Closed)

Created:
3 years, 9 months ago by Sidney San Martín

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

When navigation focuses a web contents, also activate its window. This fixes an issue where a popup opened by clicking a notification doesn't activate Chrome (and appears behind the active app) on Mac. BUG=661250 Review-Url: https://codereview.chromium.org/2729613006 Cr-Commit-Position: refs/heads/master@{#455632} (cherry picked from commit 6589abd5285d3008c44143269bdf5dc2605028cf) Review-Url: https://codereview.chromium.org/2747563002 . Cr-Commit-Position: refs/branch-heads/3029@{#128} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a6eafb8f9e388d062c5dcbf32524e9492392ef7d

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+439 lines, -331 lines)			Patch
M	chrome/browser/notifications/notification_interactive_uitest.cc	View	3 chunks	+1 line, -329 lines	0 comments	Download
A	chrome/browser/notifications/notification_interactive_uitest_mac.mm	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	chrome/browser/notifications/notification_interactive_uitest_support.h	View	1 chunk	+79 lines, -0 lines	0 comments	Download
A	chrome/browser/notifications/notification_interactive_uitest_support.cc	View	1 chunk	+299 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/test/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/notifications/notification_tester.html	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Sidney San Martín

3 years, 9 months ago (2017-03-10 23:51:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a6eafb8f9e388d062c5dcbf32524e9492392ef7d.