Web Animations: support cssOffset

Web Animations: support cssOffset

When animating the CSS shorthand property 'offset', cssOffset is used
in Web Animations keyframes.

https://w3c.github.io/web-animations/#property-name-conversion


Note that when using CSS Animations or Web Animations on a shorthand property, and discrete animation applies to one of the longhand properties, that longhand property updates at 50% progress. When using CSS Transitions on a shorthand property, and discrete animation applies to one of the longhand properties, that longhand property updates immediately.

BUG=700534
Review-Url: https://codereview.chromium.org/2747523002
Cr-Commit-Position: refs/heads/master@{#458651}
Committed: https://chromium.googlesource.com/chromium/src/+/5f543cf03508ae5cc38f69a1871b99308859a2d8

[Eric Willigers, 2017-03-11 02:16:05]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2017-03-11 02:16:20]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:16:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 04:39:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 04:39:51]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-03-13 05:11:58]

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt
(right):

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt:5:
FAIL CSS Transitions: property <offset> from [path("M0 200H 700") 500px 800deg]
to [path("M0 300H 700 Z") 600px 900deg] at (0.3) is [path('M 0 300 H 700 Z')
530px 830deg] assert_equals: expected "path ( ' M 0 200 H 700 ' ) 530px 830deg "
but got "path ( ' M 0 300 H 700 Z ' ) 530px 830deg "
Why do these fail? The description should elaborate.

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation.html
(right):

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation.html:55:
*/
We should not check in commented out code.

[Eric Willigers, 2017-03-21 05:47:14]

Description was changed from

==========
Web Animations: support cssOffset

When animating the CSS shorthand property 'offset', cssOffset is used
in Web Animations keyframes.

https://w3c.github.io/web-animations/#property-name-conversion



BUG=700534
==========

to

==========
Web Animations: support cssOffset

When animating the CSS shorthand property 'offset', cssOffset is used
in Web Animations keyframes.

https://w3c.github.io/web-animations/#property-name-conversion


Note that when using CSS Animations or Web Animations on a shorthand property,
and discrete animation applies to one of the longhand properties, that longhand
property updates at 50% progress. When using CSS Transitions on a shorthand
property, and discrete animation applies to one of the longhand properties, that
longhand property updates immediately.

BUG=700534
==========

[Eric Willigers, 2017-03-21 05:47:24]

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt
(right):

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt:5:
FAIL CSS Transitions: property <offset> from [path("M0 200H 700") 500px 800deg]
to [path("M0 300H 700 Z") 600px 900deg] at (0.3) is [path('M 0 300 H 700 Z')
530px 830deg] assert_equals: expected "path ( ' M 0 200 H 700 ' ) 530px 830deg "
but got "path ( ' M 0 300 H 700 Z ' ) 530px 830deg "
On 2017/03/13 05:11:58, alancutter wrote:
> Why do these fail? The description should elaborate.

Description updated.

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation.html
(right):

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation.html:55:
*/
On 2017/03/13 05:11:58, alancutter wrote:
> We should not check in commented out code.

Fixed.

[alancutter (OOO until 2018), 2017-03-21 05:56:44]

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt
(right):

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt:5:
FAIL CSS Transitions: property <offset> from [path("M0 200H 700") 500px 800deg]
to [path("M0 300H 700 Z") 600px 900deg] at (0.3) is [path('M 0 300 H 700 Z')
530px 830deg] assert_equals: expected "path ( ' M 0 200 H 700 ' ) 530px 830deg "
but got "path ( ' M 0 300 H 700 Z ' ) 530px 830deg "
On 2017/03/21 at 05:47:24, Eric Willigers wrote:
> On 2017/03/13 05:11:58, alancutter wrote:
> > Why do these fail? The description should elaborate.
> 
> Description updated.

In this scenario I think it's suitable to define separate expectations for CSS
Transitions vs CSS Animations. It's a bug in the test case if it expects the
wrong thing.
Use the "method" parameter to test them separately:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/animation...

[Eric Willigers, 2017-03-22 01:20:55]

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt
(right):

https://codereview.chromium.org/2747523002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/interpolation/offset-interpolation-expected.txt:5:
FAIL CSS Transitions: property <offset> from [path("M0 200H 700") 500px 800deg]
to [path("M0 300H 700 Z") 600px 900deg] at (0.3) is [path('M 0 300 H 700 Z')
530px 830deg] assert_equals: expected "path ( ' M 0 200 H 700 ' ) 530px 830deg "
but got "path ( ' M 0 300 H 700 Z ' ) 530px 830deg "
On 2017/03/21 05:56:44, alancutter wrote:
> On 2017/03/21 at 05:47:24, Eric Willigers wrote:
> > On 2017/03/13 05:11:58, alancutter wrote:
> > > Why do these fail? The description should elaborate.
> > 
> > Description updated.
> 
> In this scenario I think it's suitable to define separate expectations for CSS
> Transitions vs CSS Animations. It's a bug in the test case if it expects the
> wrong thing.
> Use the "method" parameter to test them separately:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/animation...

Done.

[alancutter (OOO until 2018), 2017-03-22 02:29:21]

lgtm

[Eric Willigers, 2017-03-22 02:29:57]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-03-22 02:30:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 04:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:33:31]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[Eric Willigers, 2017-03-22 04:34:11]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-03-22 04:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 06:54:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490157251732810,
"parent_rev": "c615c911eea856986f8daaab73b7f30860234009", "commit_rev":
"5f543cf03508ae5cc38f69a1871b99308859a2d8"}

[commit-bot: I haz the power, 2017-03-22 06:55:02]

Description was changed from

==========
Web Animations: support cssOffset

When animating the CSS shorthand property 'offset', cssOffset is used
in Web Animations keyframes.

https://w3c.github.io/web-animations/#property-name-conversion


Note that when using CSS Animations or Web Animations on a shorthand property,
and discrete animation applies to one of the longhand properties, that longhand
property updates at 50% progress. When using CSS Transitions on a shorthand
property, and discrete animation applies to one of the longhand properties, that
longhand property updates immediately.

BUG=700534
==========

to

==========
Web Animations: support cssOffset

When animating the CSS shorthand property 'offset', cssOffset is used
in Web Animations keyframes.

https://w3c.github.io/web-animations/#property-name-conversion


Note that when using CSS Animations or Web Animations on a shorthand property,
and discrete animation applies to one of the longhand properties, that longhand
property updates at 50% progress. When using CSS Transitions on a shorthand
property, and discrete animation applies to one of the longhand properties, that
longhand property updates immediately.

BUG=700534

Review-Url: https://codereview.chromium.org/2747523002
Cr-Commit-Position: refs/heads/master@{#458651}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f543cf03508ae5cc38f69a1871b...
==========

[commit-bot: I haz the power, 2017-03-22 06:55:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5f543cf03508ae5cc38f69a1871b...