Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2747483002: Fix GN bootstrap. (Closed)

Created:
3 years, 9 months ago by rayb
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org, JaideepBajwa
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN bootstrap. Added missing files. BUG=none R=jochen@chromium.org, thakis@chromium.org Review-Url: https://codereview.chromium.org/2747483002 Cr-Commit-Position: refs/heads/master@{#456229} Committed: https://chromium.googlesource.com/chromium/src/+/379e35f6f3eaa41a97f2659249509ca599749b27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
rayb
PTAL
3 years, 9 months ago (2017-03-10 18:59:33 UTC) #1
Nico
lgtm
3 years, 9 months ago (2017-03-10 19:06:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747483002/1
3 years, 9 months ago (2017-03-10 20:24:53 UTC) #6
commit-bot: I haz the power
The author rayb@ca.ibm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 9 months ago (2017-03-10 20:24:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747483002/1
3 years, 9 months ago (2017-03-10 20:42:58 UTC) #10
commit-bot: I haz the power
The author rayb@ca.ibm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 9 months ago (2017-03-10 20:43:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747483002/1
3 years, 9 months ago (2017-03-11 00:13:26 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:26:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/379e35f6f3eaa41a97f265924950...

Powered by Google App Engine
This is Rietveld 408576698