Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2747463003: Ensure clean layout for a call site of FrameSelection::contains() (Closed)

Created:
3 years, 9 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure clean layout for a call site of FrameSelection::contains() When calling FrameSelection::contains() from SelectionController::passMousePressEventToSubframe(), the layout can be dirty due to style changes performed in Document::updateHoverActiveState(). Hence, this patch updates layout for this call site. BUG=700248 TEST=hittesting/subframe_active_crash.html Review-Url: https://codereview.chromium.org/2747463003 Cr-Commit-Position: refs/heads/master@{#456313} Committed: https://chromium.googlesource.com/chromium/src/+/ebefd65d9e7285db1b4f85ef732df331f3f23fd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/hittesting/subframe_active_crash.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 9 months ago (2017-03-11 03:09:28 UTC) #5
tkent
lgtm
3 years, 9 months ago (2017-03-12 23:25:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747463003/1
3 years, 9 months ago (2017-03-12 23:25:16 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 01:07:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebefd65d9e7285db1b4f85ef732d...

Powered by Google App Engine
This is Rietveld 408576698