Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2747463002: [Merge M58] arg: Change VLOG to LOG for ArcAuthContext and fetcher. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arg: Change VLOG to LOG for ArcAuthContext and fetcher. This change VLOG(2) to LOG(WARNING) for failure reasons in ARC HTTP context preparation and background auth code fetcher. This information was missing in some user feedbacks responsible for SERVER_COMMUNICATION_ERROR failure. TEST=Ensure that log entries appear in Chrome Log BUG=700048 NOTRY=true NOPRESUBMIT=true TBR=yusukes@chromium.org Review-Url: https://codereview.chromium.org/2742643002 Cr-Commit-Position: refs/heads/master@{#455815} (cherry picked from commit f2d4ff52c748b24a2a57a6f3d3fe7573744442ba) Review-Url: https://codereview.chromium.org/2747463002 Cr-Commit-Position: refs/branch-heads/3029@{#114} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/13d308927b6a8363df6274a3cfa4b9c8f421769c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_context.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747463002/1
3 years, 9 months ago (2017-03-10 18:22:20 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:24:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13d308927b6a8363df6274a3cfa4...

Powered by Google App Engine
This is Rietveld 408576698