Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000

Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000

move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this is server side feature. No behavior change.
Merge internal change: 149180639
https://codereview.chromium.org/2746443003/

Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId.
Merge internal change: 149147915
https://codereview.chromium.org/2743883002/

Drop Packets with the multipath bit set before decryption. Protected by FLAGS_quic_reloadable_flag_quic_remove_multipath_bit.
Merge internal change: 149034371
https://codereview.chromium.org/2739323002/

Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for invalid headers stream data due to decompression error. Not protected.
Merge internal change: 148932025
https://codereview.chromium.org/2737273004/

No longer send or process the socket recieve buffer value in QUIC.  Protected by FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.
Merge internal change: 148785639
https://codereview.chromium.org/2744663004/

Remove multipath_enabled from quic_config and quic_connection. No functional change expected.
Also including clean up has_multipath_flag from test methods.
Merge internal change: 148763093
https://codereview.chromium.org/2739313002/

Delete unused code from quic_framer_test.cc
Merge internal change: 148657314
https://codereview.chromium.org/2737353005/

Remove static_assert for QuicTransmissionInfo size
(portability fix for iOS 64-bit build)
Merge internal change: 148495524
https://codereview.chromium.org/2739053004/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2747443002
Cr-Commit-Position: refs/heads/master@{#456182}
Committed: https://chromium.googlesource.com/chromium/src/+/14e0d83bacb9f07e8f9a63c1c95f92f85d3f444c

[Ryan Hamilton, 2017-03-10 17:47:14]

Description was changed from

==========
Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000

move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this
is server side feature. No behavior change.
Merge internal change: 149180639
https://codereview.chromium.org/2746443003/

Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId.
Merge internal change: 149147915
https://codereview.chromium.org/2743883002/

Drop Packets with the multipath bit set before decryption. Protected by
FLAGS_quic_reloadable_flag_quic_remove_multipath_bit.
Merge internal change: 149034371
https://codereview.chromium.org/2739323002/

Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for
invalid headers stream data due to decompression error. Not protected.
Merge internal change: 148932025
https://codereview.chromium.org/2737273004/

No longer send or process the socket recieve buffer value in QUIC.  Protected by
FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.
Merge internal change: 148785639
https://codereview.chromium.org/2744663004/

Remove multipath_enabled from quic_config and quic_connection. No functional
change expected.
Also including clean up has_multipath_flag from test methods.
Merge internal change: 148763093
https://codereview.chromium.org/2739313002/

Delete unused code from /gfe/quic/core/quic_framer_test.cc
Merge internal change: 148657314
https://codereview.chromium.org/2737353005/

Remove static_assert for QuicTransmissionInfo size
(portability fix for iOS 64-bit build)
Merge internal change: 148495524
https://codereview.chromium.org/2739053004/

R=rch@chromium.org
BUG=
==========

to

==========
Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000

move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this
is server side feature. No behavior change.
Merge internal change: 149180639
https://codereview.chromium.org/2746443003/

Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId.
Merge internal change: 149147915
https://codereview.chromium.org/2743883002/

Drop Packets with the multipath bit set before decryption. Protected by
FLAGS_quic_reloadable_flag_quic_remove_multipath_bit.
Merge internal change: 149034371
https://codereview.chromium.org/2739323002/

Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for
invalid headers stream data due to decompression error. Not protected.
Merge internal change: 148932025
https://codereview.chromium.org/2737273004/

No longer send or process the socket recieve buffer value in QUIC.  Protected by
FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.
Merge internal change: 148785639
https://codereview.chromium.org/2744663004/

Remove multipath_enabled from quic_config and quic_connection. No functional
change expected.
Also including clean up has_multipath_flag from test methods.
Merge internal change: 148763093
https://codereview.chromium.org/2739313002/

Delete unused code from quic_framer_test.cc
Merge internal change: 148657314
https://codereview.chromium.org/2737353005/

Remove static_assert for QuicTransmissionInfo size
(portability fix for iOS 64-bit build)
Merge internal change: 148495524
https://codereview.chromium.org/2739053004/

R=rch@chromium.org
BUG=
==========

[Ryan Hamilton, 2017-03-10 17:48:33]

https://codereview.chromium.org/2747443002/diff/1/net/quic/core/quic_config.h
File net/quic/core/quic_config.h (right):

https://codereview.chromium.org/2747443002/diff/1/net/quic/core/quic_config.h...
net/quic/core/quic_config.h:439: // Latched copy of
gfe2_reloadable_flag_quic_no_socket_receive_buffer.
I commented on this in the base CL, but can you fix the occurrences of this in
this CL? I'm curious why the merge script missed it.

[Ryan Hamilton, 2017-03-10 17:48:42]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 17:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 17:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 17:55:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2017-03-10 18:13:13]

Oh, looks like a new QuicErrorCode was added which means one more file needs to
be changed

../../components/domain_reliability/quic_error_mapping.cc:263:1: error: static
assertion failed: quic_error_map is not in sync with quic protocol!
 static_assert(arraysize(kQuicErrorMap) == kActiveQuicErrorCount,
 ^

[Ryan Hamilton, 2017-03-10 19:45:52]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-03-10 19:45:52]

lgtm

[commit-bot: I haz the power, 2017-03-10 19:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 21:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:04:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jokulik, 2017-03-10 21:14:57]

The CQ bit was checked by jokulik@google.com

[commit-bot: I haz the power, 2017-03-10 21:15:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 22:09:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489180497575890,
"parent_rev": "d7d72e0bfe84649004a90a0ef28d88054bee4a99", "commit_rev":
"14e0d83bacb9f07e8f9a63c1c95f92f85d3f444c"}

[commit-bot: I haz the power, 2017-03-10 22:10:26]

Description was changed from

==========
Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000

move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this
is server side feature. No behavior change.
Merge internal change: 149180639
https://codereview.chromium.org/2746443003/

Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId.
Merge internal change: 149147915
https://codereview.chromium.org/2743883002/

Drop Packets with the multipath bit set before decryption. Protected by
FLAGS_quic_reloadable_flag_quic_remove_multipath_bit.
Merge internal change: 149034371
https://codereview.chromium.org/2739323002/

Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for
invalid headers stream data due to decompression error. Not protected.
Merge internal change: 148932025
https://codereview.chromium.org/2737273004/

No longer send or process the socket recieve buffer value in QUIC.  Protected by
FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.
Merge internal change: 148785639
https://codereview.chromium.org/2744663004/

Remove multipath_enabled from quic_config and quic_connection. No functional
change expected.
Also including clean up has_multipath_flag from test methods.
Merge internal change: 148763093
https://codereview.chromium.org/2739313002/

Delete unused code from quic_framer_test.cc
Merge internal change: 148657314
https://codereview.chromium.org/2737353005/

Remove static_assert for QuicTransmissionInfo size
(portability fix for iOS 64-bit build)
Merge internal change: 148495524
https://codereview.chromium.org/2739053004/

R=rch@chromium.org
BUG=
==========

to

==========
Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000

move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this
is server side feature. No behavior change.
Merge internal change: 149180639
https://codereview.chromium.org/2746443003/

Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId.
Merge internal change: 149147915
https://codereview.chromium.org/2743883002/

Drop Packets with the multipath bit set before decryption. Protected by
FLAGS_quic_reloadable_flag_quic_remove_multipath_bit.
Merge internal change: 149034371
https://codereview.chromium.org/2739323002/

Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for
invalid headers stream data due to decompression error. Not protected.
Merge internal change: 148932025
https://codereview.chromium.org/2737273004/

No longer send or process the socket recieve buffer value in QUIC.  Protected by
FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer.
Merge internal change: 148785639
https://codereview.chromium.org/2744663004/

Remove multipath_enabled from quic_config and quic_connection. No functional
change expected.
Also including clean up has_multipath_flag from test methods.
Merge internal change: 148763093
https://codereview.chromium.org/2739313002/

Delete unused code from quic_framer_test.cc
Merge internal change: 148657314
https://codereview.chromium.org/2737353005/

Remove static_assert for QuicTransmissionInfo size
(portability fix for iOS 64-bit build)
Merge internal change: 148495524
https://codereview.chromium.org/2739053004/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2747443002
Cr-Commit-Position: refs/heads/master@{#456182}
Committed:
https://chromium.googlesource.com/chromium/src/+/14e0d83bacb9f07e8f9a63c1c95f...
==========

[commit-bot: I haz the power, 2017-03-10 22:10:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/14e0d83bacb9f07e8f9a63c1c95f...