Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2747423005: cros: Allow hotrod remote to check/uncheck a11y checkboxes for CFM oobe (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by Qiang(Joe) Xu
Modified:
6 months, 1 week ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Allow hotrod remote to check/uncheck a11y checkboxes for CFM oobe Changes: allow hotrod remote controller to check/uncheck a11y checkboxes for oobe a11y checkboxes. BUG=700128 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2747423005 Cr-Commit-Position: refs/heads/master@{#457862} Committed: https://chromium.googlesource.com/chromium/src/+/29994c2a7c27139cb3d6410f8f4c06a071b0225d

Patch Set 1 #

Patch Set 2 : improvement #

Patch Set 3 : simulate click event #

Messages

Total messages: 20 (11 generated)
Qiang(Joe) Xu
Hi xiyuan@, PTAL, thanks! This patch may have some code duplication. We probably can add ...
6 months, 1 week ago (2017-03-17 03:08:48 UTC) #4
xiyuan
On 2017/03/17 03:08:48, Qiang(Joe) Xu wrote: > Hi xiyuan@, PTAL, thanks! > > This patch ...
6 months, 1 week ago (2017-03-17 04:56:19 UTC) #9
Qiang(Joe) Xu
On 2017/03/17 04:56:19, xiyuan wrote: > On 2017/03/17 03:08:48, Qiang(Joe) Xu wrote: > > Hi ...
6 months, 1 week ago (2017-03-17 16:04:20 UTC) #11
xiyuan
On 2017/03/17 16:04:20, Qiang(Joe) Xu wrote: > On 2017/03/17 04:56:19, xiyuan wrote: > > On ...
6 months, 1 week ago (2017-03-17 16:28:10 UTC) #12
Qiang(Joe) Xu
On 2017/03/17 16:28:10, xiyuan wrote: > On 2017/03/17 16:04:20, Qiang(Joe) Xu wrote: > > On ...
6 months, 1 week ago (2017-03-17 16:44:25 UTC) #13
xiyuan
6 months, 1 week ago (2017-03-17 16:46:07 UTC) #14
xiyuan
lgtm
6 months, 1 week ago (2017-03-17 16:46:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747423005/40001
6 months, 1 week ago (2017-03-17 16:48:22 UTC) #17
commit-bot: I haz the power
6 months, 1 week ago (2017-03-17 19:50:15 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/29994c2a7c27139cb3d6410f8f4c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b