Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2747373002: Update WebVR API based on prerelease 1.1 except window and navigator interface (Closed)

Created:
3 years, 9 months ago by shaobo.yan
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, feature-vr-reviews_chromium.org, hokein.wu_gmail.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modifications : - Rename dictionary VRLayer to dictionary VRLayerInit, and update related function declarations in VRDisplay interface. - Update VRDisplayEvent type, delete disconnect and connect according to prerelease spec 1.1. This change won't affect current implementation. - Miscs: VRDisplayEvent constructor must take VRDisplayEventReason. BUG=700682

Patch Set 1 #

Patch Set 2 : Update wpt test #

Messages

Total messages: 26 (15 generated)
shaobo.yan
idl file modification: PTAL.
3 years, 9 months ago (2017-03-15 05:27:44 UTC) #2
shaobo.yan
bsheedy@: PTAL wpt test part
3 years, 9 months ago (2017-03-15 06:16:16 UTC) #4
shaobo.yan
3 years, 9 months ago (2017-03-16 00:46:08 UTC) #9
bsheedy
WPT stuff lgtm. Does this have any effect on how the API is used? If ...
3 years, 9 months ago (2017-03-16 00:58:32 UTC) #10
shaobo.yan
On 2017/03/16 00:58:32, bsheedy wrote: > WPT stuff lgtm. Does this have any effect on ...
3 years, 9 months ago (2017-03-16 01:00:31 UTC) #11
shaobo.yan
3 years, 9 months ago (2017-03-16 02:51:18 UTC) #17
shaobo.yan
haraken@: PTAL moduels_idl_files.gni, thx.
3 years, 9 months ago (2017-03-16 02:55:52 UTC) #18
haraken
On 2017/03/16 02:55:52, shaobo.yan wrote: > haraken@: PTAL moduels_idl_files.gni, thx. LGTM
3 years, 9 months ago (2017-03-16 08:34:01 UTC) #19
ddorwin
Can you more clearly state what _is_ changing in the first line of the description? ...
3 years, 9 months ago (2017-03-17 17:58:50 UTC) #21
shaobo.yan
On 2017/03/17 17:58:50, ddorwin wrote: > Can you more clearly state what _is_ changing in ...
3 years, 9 months ago (2017-03-27 08:29:18 UTC) #24
shaobo.yan
3 years, 8 months ago (2017-03-30 00:50:33 UTC) #26
cc billorr for updates.

Powered by Google App Engine
This is Rietveld 408576698