Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2747363002: Revert of arc: enable Android tracing from chrome://tracing in dev mode (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, hidehiko+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, oshima+watch_chromium.org, tracing+reviews_chromium.org, darin-cc_chromium.org, darin (slow to review), davemoore+watch_chromium.org, qsr+mojo_chromium.org, chiniforooshan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of arc: enable Android tracing from chrome://tracing in dev mode (patchset #17 id:310001 of https://codereview.chromium.org/2699833003/ ) Reason for revert: This CL seems to cause a compile failure on the CI. The error log is: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Builder__dbg_%2F84546%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout [10030/10041] LINK ./chrome_app_unittests FAILED: chrome_app_unittests (snip) ../../chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc:35: error: undefined reference to 'content::ArcTracingAgent::GetInstance()' ../../chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc:39: error: undefined reference to 'content::ArcTracingAgent::GetInstance()' ../../chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc:41: error: undefined reference to 'content::ArcTracingAgent::Delegate::~Delegate()' ../../content/browser/tracing/arc_tracing_agent.h:21: error: undefined reference to 'vtable for content::ArcTracingAgent::Delegate' ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function clang: error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > arc: enable Android tracing from chrome://tracing in dev mode > > To enable tracing from chrome://tracing, we create a Mojo interface > for host side to trigger tracing in Android. > > The trace is written into debugfs/tracefs in dev-mode, and is read back > by debugd. > > Related changes: > - http://crrev.com/2699833003 > - http://ag/1915548 > > BUG=653795 > TEST=Run chrome://tracing and see events from Android. > > Review-Url: https://codereview.chromium.org/2699833003 > Cr-Commit-Position: refs/heads/master@{#456985} > Committed: https://chromium.googlesource.com/chromium/src/+/0b110db84a13d9087ddf55b5e99d961e54f55e16 TBR=yusukes@chromium.org,lhchavez@chromium.org,bccheng@chromium.org,reveman@chromium.org,shunhsingou@google.com,dsinclair@chromium.org,dcheng@chromium.org,derat@chromium.org,primiano@chromium.org,oysteine@chromium.org,alexmos@chromium.org,shunhsingou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653795 Review-Url: https://codereview.chromium.org/2747363002 Cr-Commit-Position: refs/heads/master@{#456999} Committed: https://chromium.googlesource.com/chromium/src/+/5b91c606652e6b648fc229a05573996510ef57ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -391 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_service_launcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/arc/tracing/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/arc_bridge_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/arc_bridge_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/arc/arc_bridge_service.h View 3 chunks +0 lines, -3 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 2 chunks +2 lines, -6 lines 0 comments Download
D components/arc/common/tracing.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/tracing/arc_tracing_agent.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/tracing/arc_tracing_agent.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 8 chunks +7 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tzik
Created Revert of arc: enable Android tracing from chrome://tracing in dev mode
3 years, 9 months ago (2017-03-15 05:14:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747363002/1
3 years, 9 months ago (2017-03-15 05:15:21 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 05:17:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b91c606652e6b648fc229a05573...

Powered by Google App Engine
This is Rietveld 408576698